Andras/BoundlessFlowCampus2K

Fork 0

#487-Cleanup-in-DockerCompose #559

Merged

c24elipe merged 7 commits from #487-Cleanup-in-DockerCompose into team_2_week_3

2026-04-28 12:08:50 +00:00

c24elipe commented

2026-04-24 14:03:41 +00:00

Collaborator

Cleaned up the compose.yaml file.

c24elipe added the

cleanup

needs review

labels

2026-04-24 14:03:41 +00:00

c24elipe self-assigned this

2026-04-24 14:03:41 +00:00

j21marbr was assigned by c24elipe

2026-04-24 14:03:41 +00:00

c24elipe added 4 commits

2026-04-24 14:03:42 +00:00

Added versions and a health check 5dea44ce16

Fix mosquitto-init volumes dccc10d81f

Merge branch '#487-Cleanup-in-DockerCompose' of https://git.webug.se/Andras/BoundlessFlowCampus2K into #487-Cleanup-in-DockerCompose b8b69aa14f

Reorderd, and fixed some syntax af0ab451f7

c24elipe requested review from b25marem

2026-04-27 06:53:20 +00:00

b25marem commented

2026-04-27 10:51:33 +00:00

Collaborator

Review on #559

Whats done

Reviewed the cleanup of DockerCompose/compose.yaml for issue #487.

Tested on Windows using Docker Desktop

Focused on checking that the docker compose setup actually works after the cleanup.
Ran:
- docker compose config: syntax is valid
- docker compose up -d :containers start
- docker compose ps: checked status of all services
- Looked at logs for failing services (middleware, readTempSensorMockup, readEnergySensor)
Tested with:
- original .env
- updated MQTT credentials (mqttuser / mqttpasswords) from team message
App starts partially
- postgres and mosquitto are healthy
- several services are running fine
- but multiple services keep restarting:
  - middleware
  - readTempSensorMockup
  - readEnergySensor
  - roomBookingDbHandler
- frontend was also unhealthy at first
From logs:
- MQTT connection fails with NotAuthorized
- repeated MqttConnectingFailedException errors

Inspected following files

DockerCompose/compose.yaml`
- Indentation/code styling
  - Cleaner than before, easier to read overall
- Comments
  - Some helpful comments, nothing major missing
- General code quality
  - Improvements:
    image versions added
    healthchecks added
    clearer network structure (frontend/backend)
  - Issues:
    several services depend on MQTT but fail to connect
    system is not stable after startup

What needs to be done

DockerCompose/compose.yaml
- Fix MQTT setup so that:
  .env
  mosquitto config
  all services
  use the same credentials
- Fix crashing services:
  middleware
  readTempSensorMockup
  readEnergySensor
  roomBookingDbHandler
- Make sure docker compose up -d results in a fully working system (no restarts)
General
- The system should work without requiring manual .env changes that aren’t documented

Conclusion

The cleanup improves structure and readability of the compose file.
However, the system does not run correctly in its current state.
Multiple services fail due to MQTT authentication issues.
PR is not ready for merge.

# Review on #559 ## Whats done Reviewed the cleanup of DockerCompose/compose.yaml for issue #487. ### Tested on Windows using Docker Desktop + Focused on checking that the docker compose setup actually works after the cleanup. + Ran: + docker compose config: syntax is valid + docker compose up -d :containers start + docker compose ps: checked status of all services + Looked at logs for failing services (middleware, readTempSensorMockup, readEnergySensor) + Tested with: + original .env + updated MQTT credentials (mqttuser / mqttpasswords) from team message + App starts partially + postgres and mosquitto are healthy + several services are running fine + but multiple services keep restarting: - middleware - readTempSensorMockup - readEnergySensor - roomBookingDbHandler + frontend was also unhealthy at first + From logs: + MQTT connection fails with NotAuthorized + repeated `MqttConnectingFailedException` errors ### Inspected following files + DockerCompose/compose.yaml` + Indentation/code styling + Cleaner than before, easier to read overall + Comments + Some helpful comments, nothing major missing + General code quality + Improvements: image versions added healthchecks added clearer network structure (frontend/backend) + Issues: several services depend on MQTT but fail to connect system is not stable after startup ## What needs to be done + DockerCompose/compose.yaml + Fix MQTT setup so that: .env mosquitto config all services use the same credentials + Fix crashing services: middleware readTempSensorMockup readEnergySensor roomBookingDbHandler + Make sure docker compose up -d results in a fully working system (no restarts) + General + The system should work without requiring manual .env changes that aren’t documented ## Conclusion + The cleanup improves structure and readability of the compose file. + However, the system does not run correctly in its current state. + Multiple services fail due to MQTT authentication issues. + PR is **not ready for merge**.

c24elipe changed target branch from main to team_2_week_3

2026-04-28 08:00:33 +00:00

c24elipe added 1 commit

2026-04-28 08:41:02 +00:00

Removed name 112cd9aade

c24elipe added 1 commit

2026-04-28 10:44:16 +00:00

Fixed frontend being in wrong network 21ca8c7256

c24elipe commented

2026-04-28 11:01:55 +00:00

Author

Collaborator

The error described with MQTT and related services not starting has not been observed on my end.
(readEnergySensor has a known issue that is fixed on the team 1 branch)

The error described with MQTT and related services not starting has not been observed on my end. (readEnergySensor has a known issue that is fixed on the team 1 branch) ![image](/attachments/04f7a8d2-2959-4cb6-9c3a-f9f529bd50a5)

image.png

365 KiB

c24elipe commented

2026-04-28 11:02:43 +00:00

Author

Collaborator

I have also had others, using Linux machines, try it out, and similar results are shown then.