#573-Fill the screen automatically with rows. #599
Closed
a24danwe
wants to merge 0 commits from
#573-add-enough-grid-rows into team_2_week_3
pull from: #573-add-enough-grid-rows
merge into: Andras:team_2_week_3
Andras:main
Andras:#922-Implement-a-fucntion-to-delete-a-account-
Andras:716-Energy-Tests
Andras:#964-Implement-Meue-Service
Andras:715_Create_tests_roomBooking
Andras:#1057-navbar-color-change
Andras:1008-localization-on-views-part-1
Andras:team_1_week_7
Andras:909-Save-PDFs
Andras:1072-update-support-page
Andras:#1073-remove-bottom-border
Andras:team_2_week_7
Andras:1052-UnixRebuild.sh-run-in-paralell
Andras:#1021-Missing-icons-in-add-new-cards-menu
Andras:1044-&-987-Create-script-expansion
Andras:write-in-wiki-about-the-playwrite-#1043
Andras:#1069-search-for-swedish-cards
Andras:1032-Better-and-X-for-the-cards
Andras:991-frontend-sign-up
Andras:#1033-fix-button-translate-view
Andras:1061-Rebuild-script-improvements
Andras:#1045-fix-shmi-temp-view
Andras:1064-todo-checkbox-enable-all-time
Andras:#1001-cleanup-middleware
Andras:1012-update-the-boundlessflowCampus2k-readme
Andras:765-fix-visible-rows-edit-mode
Andras:vasttrafik-clean
Andras:#934-solar-panel-mockup-v2
Andras:#900-logger-middleware-new
Andras:#1046-Fix-broken-localization-in-settings
Andras:#1039-dependencies-with-mid-vulnerabilities
Andras:#900-logger-for-middleware
Andras:#989
Andras:temp_branch_week_7
Andras:#1027-move-footer-down
Andras:1037-missing-login-functionality
Andras:1023-The-clock-pulsates-after-each-second
Andras:#1015-button-visibility
Andras:1029-fix-preview
Andras:#1027-fix-footer-bug
Andras:#961-new-card-design
Andras:team_2_week_6
Andras:team_1_week_6
Andras:541-implement-vasttrafik-card
Andras:1006-update-css-in-frontend-pages
Andras:748_change_creation_endpoint_roomBooking
Andras:#977-Translator-API
Andras:#845-new-energy-endpoints
Andras:635-Sub-compose-files-re-branch
Andras:988-different-passwords-for-databases
Andras:#920-change-password
Andras:#934-solar-panel-mockup
Andras:1000_Fix-pg_cron-sql-setup-for-postgres-image
Andras:982-enhance-toggle-toolbar
Andras:#861-localization-change-all-printed-text-Part-2
Andras:938-fix-view-button-mobile
Andras:Add---remove-orphans-to-the-rebuild-script-#983
Andras:835-loginService-JWT-v2
Andras:962-new-button-temperatureView-sensors
Andras:#893-Create-test-in-frontend-for-responsiveness
Andras:894-tempservice-class-diagram
Andras:934-solar-panel-mockup
Andras:Temp-Main-Week-5
Andras:915-Windows-deployment-script
Andras:835-loginService-JWT
Andras:#908-new-logo
Andras:#952-Center-Temperature-graph
Andras:team_2_week_5
Andras:team_1_week_5
Andras:#442-temp-month-and-year-styling
Andras:issue-836-add-card-placeholders
Andras:#920-possibility-to-change-password
Andras:879-season-themes-functinality
Andras:737-Parking-restructure-re-branch
Andras:#876-logger-loginService
Andras:Enhance-logging-deploy-#838
Andras:#724-restructuring-of-roombooking-service-code
Andras:866-views-get-scrollbars-eaven-when-they-fit
Andras:847-enhance-settings
Andras:803-update-css-files-frontend-components
Andras:798-add-card-horizontal-fix
Andras:731-Service-creation-script
Andras:837-temperature-error-messages-team1
Andras:#797-Restructuring-energy-service
Andras:840-move-logo-navbar
Andras:807-fix-button-layout
Andras:833-change-temperature-error-messages
Andras:#429-select-year-temperature
Andras:color-tech-test
Andras:#789-Socials-Page
Andras:Change-title-Description-#815
Andras:Old-Navbar-On-Refresh-#770
Andras:#804-fix-preview-size
Andras:#778-default-card-sizes
Andras:800-enhance-toolbar-phone
Andras:#787-tempSesnorMockupTests-outdated-unit-tests
Andras:776-hide-toolbar-button
Andras:749-create-job-api
Andras:#607-auto-view-registry
Andras:741-textview-card-improvements
Andras:temp_branch_week_5
Andras:team_2_week_4
Andras:team_1_week_4
Andras:#691-move-ITempService-to-a-separate-file
Andras:#730-energy-view
Andras:745-text-footer-fix
Andras:Deployment-script-#701
Andras:743-fix-position-logo-phone
Andras:722-fix-year-month-api-connection
Andras:#723-clcok-view
Andras:708-hamburger-position
Andras:#690-Implement-password-hashing
Andras:#703-missing-required-packages-in-install-scripts
Andras:#732-footer-centered
Andras:729-textview-cant-make-new-rows
Andras:#541-Västtrafik-card
Andras:#697-remove-mqtt-from-roombooking
Andras:#702-auto-update-temperature
Andras:693-fix-temperature-graph-preview-centering
Andras:649-Footer-not-moving-with-grid
Andras:673-fix-respond-remove-phone
Andras:feature/501-implement-loginservice-api
Andras:#620-update-prettier-config
Andras:#664-Logo-change-depending-on-device
Andras:663-responsive-add-card-modal
Andras:#672-centering-spans
Andras:week_4_temp_branch
Andras:667-fix-resize-textview
Andras:657-Code-cleanup-after-merge
Andras:#659-Grid-cells-should-have-the-same-dimensions-when-zooming-in/out
Andras:#628-Fix-team-2-tmp-service-V4
Andras:API-Calls-gets-resent-alot
Andras:#652-fix-scrollbars-on-cards
Andras:602-new-file-structure
Andras:#640-hamburger-bug
Andras:temp-branch-week-3
Andras:#628-Fix-team-2-tmp-service-V2
Andras:#477-Update-Electricity-Data
Andras:team_2_week_3
Andras:team_1_week_3
Andras:#459-TempratureGraph-Fix-and-APIhook
Andras:625-increase-size-URL-schedule
Andras:#628-Fix-team-2-tmp-service
Andras:#369-implement-hamburger-menu
Andras:#585-Implement-Mobile-toolbar
Andras:feature/expand-parking-#254
Andras:570-Add-weather-symbols
Andras:#630-add-max-sizes-view-config
Andras:#608-fix-tempreture-graph
Andras:544-fix-tooltip-styling
Andras:#610-reset-modal-background-not-displaying
Andras:539-add-card-modal
Andras:#578-Implement-navbar-to-be-responsive
Andras:616-fix-tooltip
Andras:#617-values-for-month-week-year
Andras:613-fix-logo-chrome-edge
Andras:#605-new-custom-button
Andras:#377-Implement-Sudoku-View
Andras:567-installation-script-missing-dotnet-dependency
Andras:#351-roombooking-functionality-and-restructuring
Andras:551-add-new-logo
Andras:#484-weekly-aggregated-temperature
Andras:#507-breakout-danger-modal
Andras:AddNewView-Faulty-Parameter-564
Andras:#547-fix-schedule-card-resize
Andras:531-break-out-new-card-functionality
Andras:533-config-tooltip
Andras:525-fix-booking-card
Andras:#538-Footer-scale-bug
Andras:516-grid-background-update
Andras:527-stay-edit-mode-refresh
Andras:506-mode-and-style-bug
Andras:513-cards-button-panel
Andras:521-footer-is-too-far-up
Andras:483-temperature-latest-return-error
Andras:#377-sudoko-view
Andras:#500-fix-card-enlargement
Andras:fixes/parking-service-#478
Andras:forecastview-weather-fix
Andras:#499-Missing-unit-tests-for-tempService
Andras:#508-break-out-toggle-from-dashboard-with-css
Andras:#380-new-cards-with-doNotCompact-grid-setting
Andras:Remove-dropshadow-arrows-#510
Andras:#497-reset-layout-btn-in-edit-mode
Andras:Fix-empsensorMockup-WorkWhithMiddleware
Andras:#494-fix-map-view-scaling
Andras:#493-Optimize-build-script
Andras:492-standards-card-errors
Andras:team_2_week_2
Andras:team_1_week_2
Andras:#376-SMHI-forecast-view-design
Andras:#19-dynamic-table-database
Andras:469-bigger-resize-closing-buttons
Andras:#126-ElectricityDataMockup
Andras:#406-tempSensorMockup-fix
Andras:#452-Grid-background-does-not-expand-with-grid
Andras:#458-Cleanup-exports
Andras:#464-Saving-card-content
Andras:#335-empty-card
Andras:428-text-card-to-notes
Andras:#311-fix-outlines-when-moving-cards
Andras:263-show-grid-when-in-grid-mode
Andras:424-create-seperate-css-files-for-components
Andras:Change-tab-icon-to-new-logo-#446
Andras:feature/room-booking-#43
Andras:modalCard
Andras:#339-Big-card-for-all-temperature-sensors
Andras:#386-Xunit-tests-for-for-parkingApiMockup-roomBookingMockup
Andras:hotfix/parking-api-dependecy-issue-build-#378
Andras:#279-Grid-layout-breakout
Andras:392-edit-language-standards-all-files
Andras:#369-Implement-hamburger-menu-in-the-navbar-
Andras:#289-fix-interactivity-with-cards
Andras:#399-tempSensorMockupTest-stopped-working-after-weekly-merge
Andras:#341-add-cards-to-error-views
Andras:374-card-scales-when-moved-bug
Andras:#375-Change-background
Andras:#345-update-logo-homepage
Andras:#319-Add-test-directories-to-all-C#-dirs
Andras:Fix-tempSensor-fel-HTTP500
Andras:TEMP-Testing-script
Andras:#315-build-script-fix-team-2
Andras:#312-fix-btn-css-team-2-fix
Andras:#313-404-routing-fix-team-2
Andras:temp-week-2-merge-branch
Andras:team_2_week_1
Andras:feature/#127-parking-api-databas-connection
Andras:team_1_week_1
Andras:#295-fixed-bugs-on-cards
Andras:#266-make-a-footer
Andras:#219-&-#208-Build-script-optimization
Andras:#20-aggregated-temp-for-month-year
Andras:#228-parking-frontend
Andras:199-research-grid-opening-closing-cards
Andras:#221-User-tables-for-future-database
Andras:#161-Integrate-Jest-testing-framework-to-project
Andras:fixes-issues-132
Andras:#107-Create-front-end-component-for-dynamically-changing-graph
Andras:#173-Save-User-Settings
Andras:#202-local-server-solution
No reviewers
b25marem
Labels
Clear labels
Only use this label for critical tasks that are project-scope,and must be addressed ASAP.
Something is not working
Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)
Issue to close
This issue or pull request already exists
New feature
Need some help
Something is wrong
Issue needs input from product owner or customer
issue is in need of review
More information is needed
This Issue has been reviewed
use this for security-related issues
Team 1 is responsible for this issue
Team 2 is responsible for this issue
Reserved for top-level, project-wide issues.
This won't be fixed
_CRITICAL_
Only use this label for critical tasks that are project-scope,and must be addressed ASAP.
API
app
backEnd
Blocked-waiting-for-further-changes
bug
Something is not working
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)
close
Issue to close
design
duplicate
This issue or pull request already exists
enhancement
New feature
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
Need some help
invalid
Something is wrong
last-week-issue-to-fix
library
low-priority
needs input
Issue needs input from product owner or customer
needs review
issue is in need of review
not-implemented.
project documentation
question
More information is needed
research
reviewed
This Issue has been reviewed
Script
security
use this for security-related issues
SQL
style
Team 1
Team 1 is responsible for this issue
Team 2
Team 2 is responsible for this issue
team leaders
test-creation
testing
topLevel
Reserved for top-level, project-wide issues.
unassigned
Under-review
wontfix
This won't be fixed
No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
Andras/BoundlessFlowCampus2K!599
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "#573-add-enough-grid-rows"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The problem was that initially in the edit mode there was not enough rows to fill the screen. This uses the window height and row height to dynamically calculate the minimum number of rows needed, ensuring the grid fills the space.
Fill the screen automatically with gridRows.to Fill the screen automatically with rows.Fill the screen automatically with rows.to #573-Fill the screen automatically with rows.Review on #573
Whats done
Tested on Windows 11 using Edge
Inspected following files
What needs to be done
Conclusion
Needs minor improvement before merge.
Thank you for the review!
I removed the reservedHeight since I think that the height is not constant.
I adjusted rowheight to include the whitespace between each row, now it is totalRowHeight.
Tested again after the latest changes.
The calculation is improved, but there is still a visible gap above the footer.
The issue is not fully resolved yet.
In order to include this into the next weekly branches I will accept the current changes and create a new issue for this. This wont break anything else.
Merged!
Pull request closed