Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

#573-Fill the screen automatically with rows. #599

Closed
a24danwe wants to merge 0 commits from #573-add-enough-grid-rows into team_2_week_3
pull from: #573-add-enough-grid-rows
merge into: Andras:team_2_week_3
Conversation 7 Commits - Files changed -
a24danwe commented 2026-04-27 15:05:46 +00:00
Collaborator
Copy link
No description provided.
a24danwe commented 2026-04-27 15:10:40 +00:00
Author
Collaborator
Copy link

The problem was that initially in the edit mode there was not enough rows to fill the screen. This uses the window height and row height to dynamically calculate the minimum number of rows needed, ensuring the grid fills the space.

The problem was that initially in the edit mode there was not enough rows to fill the screen. This uses the window height and row height to dynamically calculate the minimum number of rows needed, ensuring the grid fills the space.
a24danwe changed title from Fill the screen automatically with gridRows. to Fill the screen automatically with rows. 2026-04-27 21:47:45 +00:00
a24danwe changed title from Fill the screen automatically with rows. to #573-Fill the screen automatically with rows. 2026-04-27 21:48:17 +00:00
b25marem commented 2026-04-28 08:28:21 +00:00
Collaborator
Copy link
No description provided.
image.png
5.1 KiB
image.png
b25marem commented 2026-04-28 08:28:36 +00:00
Collaborator
Copy link

Review on #573

Whats done

Tested on Windows 11 using Edge

  • Tested edit mode grid behavior
  • App starts correctly
    • Grid fills most of the screen
    • Layout looks stable
    • A small gap is visible above the footer

Inspected following files

  • frontend/src/components/Dashboard/Dashboard.js
    • Indentation/code styling
      • Follows prettier
    • Naming convention
      • Naming is clear and follows convention
    • Comments
      • Comments are understandable
    • General code quality
      • Logic is simple and easy to follow

What needs to be done

  • frontend/src/components/Dashboard/Dashboard.js
    • Grid does not fully fill the screen (gap above footer)
    • The issue is likely caused by the use of a fixed reservedHeight value (250), which may not match the actual height of header/footer on all screens

Conclusion

  • The feature improves the layout
  • However, the grid does not fully fill the screen

Needs minor improvement before merge.

# Review on #573 ## Whats done ### Tested on Windows 11 using Edge + Tested edit mode grid behavior + App starts correctly + Grid fills most of the screen + Layout looks stable + A small gap is visible above the footer ### Inspected following files + frontend/src/components/Dashboard/Dashboard.js + Indentation/code styling + Follows prettier + Naming convention + Naming is clear and follows convention + Comments + Comments are understandable + General code quality + Logic is simple and easy to follow ## What needs to be done + frontend/src/components/Dashboard/Dashboard.js + Grid does not fully fill the screen (gap above footer) + The issue is likely caused by the use of a fixed reservedHeight value (250), which may not match the actual height of header/footer on all screens ## Conclusion + The feature improves the layout + However, the grid does not fully fill the screen Needs minor improvement before merge.
a24danwe commented 2026-04-28 09:44:10 +00:00
Author
Collaborator
Copy link

Thank you for the review!

I removed the reservedHeight since I think that the height is not constant.

I adjusted rowheight to include the whitespace between each row, now it is totalRowHeight.

Thank you for the review! I removed the reservedHeight since I think that the height is not constant. I adjusted rowheight to include the whitespace between each row, now it is totalRowHeight.
b25marem commented 2026-04-28 10:16:28 +00:00
Collaborator
Copy link

Tested again after the latest changes.

The calculation is improved, but there is still a visible gap above the footer.

The issue is not fully resolved yet.

Tested again after the latest changes. The calculation is improved, but there is still a visible gap above the footer. The issue is not fully resolved yet.
image.png
4.6 KiB
image.png
a24vinla commented 2026-04-29 06:25:10 +00:00
Collaborator
Copy link

In order to include this into the next weekly branches I will accept the current changes and create a new issue for this. This wont break anything else.

In order to include this into the next weekly branches I will accept the current changes and create a new issue for this. This wont break anything else.
👍 1
a24vinla commented 2026-04-29 07:07:27 +00:00
Collaborator
Copy link

Merged!

Merged!
a24vinla closed this pull request 2026-04-29 07:07:29 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
b25marem
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
a24danwe
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!599
No description provided.