Andras/BoundlessFlowCampus2K

Fork 0

#610 Bug-fix - Missing background-color added to style. #611

Merged

b24johka merged 2 commits from #610-reset-modal-background-not-displaying into team_1_week_3

2026-04-28 12:42:57 +00:00

f21marfo commented

2026-04-28 09:33:46 +00:00

Collaborator

Added missing background-color parameter to DangerModal.module.css.

Added missing background-color parameter to DangerModal.module.css. ![image](/attachments/ea73f53c-8f8e-4972-9f23-d1393a9b9aab)

image.png

98 KiB

f21marfo added the

needs review

label

2026-04-28 09:33:46 +00:00

f21marfo added 1 commit

2026-04-28 09:33:47 +00:00

Added missing background-color: parameter. 0adb930de1

Added missing background-color parameter to DangerModal.module.css.

b24johka requested review from b24krila

2026-04-28 10:00:04 +00:00

f21marfo added the

bug

label

2026-04-28 10:09:06 +00:00

b24krila commented

2026-04-28 10:22:31 +00:00

Collaborator

Review on #611

What has been Done.

Reviewed code and tested so that DangerModal is displayed correctly.

Tested On Windows using Google Chrome.

App starts
Reset button works
The background color appears when pressing the reset button.

Inspected the following file "DangerModal.module.css.

The css does not follow our conventions and rules.
- We are supposed to use hex codes for colors
- all classes, id, attributes should be lowercase and separation should be made with a dash "-".
- all declarations within the rule set should be ordered alphabetically.

What Needs to be done.

fix the code to follow our conventions and rules

Conclusion

The issue is technically fixed and can be merged but there are problems with the code standard based on our conventions stated here.

### Review on #611 ### What has been Done. Reviewed code and tested so that DangerModal is displayed correctly. ### Tested On Windows using Google Chrome. - App starts - Reset button works - The background color appears when pressing the reset button. ### Inspected the following file "DangerModal.module.css. - The css does not follow our conventions and rules. - We are supposed to use hex codes for colors - all classes, id, attributes should be lowercase and separation should be made with a dash "-". - all declarations within the rule set should be ordered alphabetically. - ### What Needs to be done. - fix the code to follow our conventions and rules ### Conclusion The issue is technically fixed and can be merged but there are problems with the code standard based on our conventions stated [here](https://git.webug.se/Andras/BoundlessFlowCampus2K/wiki/CSS-Coding-Convention).

b24krila removed the

needs review

label

2026-04-28 10:23:20 +00:00

f21marfo commented

2026-04-28 10:35:31 +00:00

Author

Collaborator

In regards to the first point, RGBA is generally recommended for transparencies, as they are easier to understand and adjust. Hex codes are best used for solid colors.

I'm going to dispute part of this review, as the ONLY thing that was changed, was literally the addition of one single line of code. Which means the second and third point are beyond the scope of this pull request. (Refactoring would be a separate issue entirely) In regards to the first point, RGBA is generally recommended for transparencies, as they are easier to understand and adjust. Hex codes are best used for solid colors.

b24krila commented

2026-04-28 10:45:13 +00:00

Collaborator

@f21marfo wrote in #611 (comment):

I'm going to dispute part of this review, as the ONLY thing that was changed, was literally the addition of one single line of code. Which means the second and third point are beyond the scope of this pull request. (Refactoring would be a separate issue entirely)

In regards to the first point, RGBA is generally recommended for transparencies, as they are easier to understand and adjust. Hex codes are best used for solid colors.

Fair, i agree, which is why i have brough the issue with the conventions to the coordinator and leader since when checking for this i also looked at other css files and they all have these issues which is a problem since these should be hard "rules" we follow to make sure that our css files have a clear standard.

@f21marfo wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/611#issuecomment-6324: > I'm going to dispute part of this review, as the ONLY thing that was changed, was literally the addition of one single line of code. Which means the second and third point are beyond the scope of this pull request. (Refactoring would be a separate issue entirely) > > In regards to the first point, RGBA is generally recommended for transparencies, as they are easier to understand and adjust. Hex codes are best used for solid colors. Fair, i agree, which is why i have brough the issue with the conventions to the coordinator and leader since when checking for this i also looked at other css files and they **all** have these issues which is a problem since these should be hard "rules" we follow to make sure that our css files have a clear standard.

👍 1

b24krila commented

2026-04-28 10:49:12 +00:00

Collaborator

And for that second part about RGBA i believe that should be added to the wiki as well because as it stands in our wiki only hex codes should be used.