#630-add-max-sizes-view-config #632

Closed

j21marbr wants to merge 0 commits from #630-add-max-sizes-view-config into team_2_week_3

j21marbr commented

2026-04-28 14:57:15 +00:00

Collaborator

Changes:
Added sizeConfig to new views so maxW and maxH are used.

Changes: Added sizeConfig to new views so maxW and maxH are used.

j21marbr added 1 commit

2026-04-28 14:57:15 +00:00

Added sizeConfig to new view e6eb06da28

a24vinla requested review from b23albst

2026-04-29 06:23:33 +00:00

b24erika added the

frontEnd

Team 2

needs review

labels

2026-04-29 06:49:25 +00:00

b23albst commented

2026-04-29 06:57:36 +00:00

Collaborator

Review on #632

Whats done

I tested that the max sizes for cards worked and that nothing else broke

Tested on ubuntu using firefox

App starts
- The cards cannot be resized to be larger than the max width and height.
- However, the default view config is used for all cards, so max size is 6h 4w (on my screen), even for the views with custom config.
- I checked with console logs, and the constant customConfig in getViewSizeConfig is an empty object for all views.

Inspected following files frontend/src/components/Dashboard/Dashboard.js

Dashboard.js
- Indentation/code styling
  - Indentation is ok
- Naming convention
  - Naming convention is followed
- Comments
  - No comments for the added code, but as it is only one self explanatory line, this is fine

What needs to be done

Fix getViewSizeConfig function in viewConfig.js to return custom configs when available, but this should be a separate issue.

Conclusion

Code works as intended and nothing breaks.
As the only problems encountered are out of scope for this issue, I think this is ready to be merged

# Review on #632 ## Whats done I tested that the max sizes for cards worked and that nothing else broke ### Tested on ubuntu using firefox + App starts + The cards cannot be resized to be larger than the max width and height. + However, the default view config is used for all cards, so max size is 6h 4w (on my screen), even for the views with custom config. + I checked with console logs, and the constant customConfig in getViewSizeConfig is an empty object for all views. ### Inspected following files frontend/src/components/Dashboard/Dashboard.js + Dashboard.js + Indentation/code styling + Indentation is ok + Naming convention + Naming convention is followed + Comments + No comments for the added code, but as it is only one self explanatory line, this is fine ## What needs to be done + Fix getViewSizeConfig function in viewConfig.js to return custom configs when available, but this should be a separate issue. ## Conclusion + Code works as intended and nothing breaks. + As the only problems encountered are out of scope for this issue, I think this is ready to be merged