c24carso commented

Collaborator

Added auto refresh to TemperatureView. Every 15 seconds a counter increases which causes the temperature card to check for new data.
A side note, the time shown on screenshots is when the sensor recorded the reading, not when the card refreshed.

Added auto refresh to TemperatureView. Every 15 seconds a counter increases which causes the temperature card to check for new data. A side note, the time shown on screenshots is when the sensor recorded the reading, not when the card refreshed. ![Screenshot 2026-05-04 172116](/attachments/c8549b27-3bf2-45c4-be32-444d6a11daa4)![Screenshot 2026-05-04 172125](/attachments/284a8d72-0795-41b7-a551-d77899703473)

Screenshot 2026-05-04 172116.png

12 KiB

Screenshot 2026-05-04 172125.png

12 KiB

c24carso added the

needs review

label

2026-05-04 15:27:31 +00:00

c24carso added 1 commit

2026-05-04 15:27:32 +00:00

#702 Auto update TemperatureView fc67f35d08

Added auto refresh to TemperatureView. Every 15 seconds a counter increases which causes the temperature data to be fetched again.

c24carso referenced this pull request

2026-05-04 15:29:45 +00:00

Automatically update content of cards. #702

c24carso commented

2026-05-04 15:32:22 +00:00

Author

Collaborator

Unit test added for useTemperature that verifies the hook refetches data when the refresh counter changes.

a22erigr requested review from j21marbr

2026-05-05 07:23:47 +00:00

j21marbr commented

2026-05-05 09:01:10 +00:00

Collaborator

Review on #720

Whats done

Tested on macOS using Chrome

App starts
- Checked that temperature data is displayed correctly.
- Verified that the temperature data updates automatically every 15 seconds.
- Tested switching between sensors.

Inspected following files

TemperaturView.js
- Indentation/code styling
  - Follows standard
- Naming convention
  - Follows standard
- Comments
  - Looks good
- General code quality
  - The refetch logic is well implemented and works as expected
useTemperature.js
- Indentation/code styling
  - Follows standard
- Naming convention
  - Follows standard
- Comments
  - Looks good
- General code quality
  - No issues found
useTemperature.test.js
- Indentation/code styling
  + Follows standard
  - Naming convention
    - Follows standard
  - Comments
    - Looks good
  - General code quality
    - The test is clear and verifies that data is refetched when refreshCount changes

What needs to be done

No issues found.

Conclusion

Works as intended and the code is ready to be merged.

# Review on #720 ## Whats done ### Tested on macOS using Chrome + App starts + Checked that temperature data is displayed correctly. + Verified that the temperature data updates automatically every 15 seconds. + Tested switching between sensors. ### Inspected following files + TemperaturView.js + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Looks good + General code quality + The refetch logic is well implemented and works as expected + useTemperature.js + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Looks good + General code quality + No issues found + useTemperature.test.js + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Looks good + General code quality + The test is clear and verifies that data is refetched when refreshCount changes ## What needs to be done + No issues found. ## Conclusion + Works as intended and the code is ready to be merged.