Andras/BoundlessFlowCampus2K

Fork 0

722-fix frontend connection for temperature year and month endpoints #747

Merged

a22erigr merged 1 commit from 722-fix-year-month-api-connection into team_2_week_4

2026-05-05 14:11:53 +00:00

b25marem commented

2026-05-05 10:44:24 +00:00

Collaborator

Whats done

Fixed API connection for Average temperature year
Fixed API connection for Average temperature year and month
Removed hardcoded values and made year/month dynamic
Fixed 404 errors caused by incorrect month data

Tested on Windows using Edge

Verified year endpoint works
Verified month endpoint works
Confirmed correct API calls (/api/temperature/{year}/{month})

## Whats done + Fixed API connection for Average temperature year + Fixed API connection for Average temperature year and month + Removed hardcoded values and made year/month dynamic + Fixed 404 errors caused by incorrect month data ### Tested on Windows using Edge + Verified year endpoint works + Verified month endpoint works + Confirmed correct API calls (/api/temperature/{year}/{month})

b25marem added the

needs review

label

2026-05-05 10:44:24 +00:00

b25marem added 1 commit

2026-05-05 10:44:24 +00:00

fix frontend connection for temperature year and month endpoints 477af34b14

a22erigr requested review from j21marbr

2026-05-05 13:09:23 +00:00

j21marbr added

reviewed

and removed

needs review

labels

2026-05-05 13:38:54 +00:00

j21marbr commented

2026-05-05 13:48:03 +00:00

Collaborator

Review on #747

Whats done

Tested on macOS using Chrome

App starts
- Checked that temperature data for year and month is displayed correctly.
- Verified API calls use correct endpoints /api/temperature/{year} and /api/temperature/{year}/{month}

Inspected following files

TemperatureMonthView.js
- Indentation/code styling
  - Follows standard
- Naming convention
  - Follows standard
- Comments
  - Looks good
- General code quality
  - Work as expected
TemperatureYearView.js
- Indentation/code styling
  - Follows standard
- Naming convention
  - Follows standard
- Comments
  - Looks good
- General code quality
  - No issues found
useTemperatureByMonth.js
- Indentation/code styling
  + Follows standard
  - Naming convention
    - Follows standard
  - Comments
    - Looks good
  - General code quality
    - API calls are correct and month values work as expected
useTemperatureByYear.js
- Indentation/code styling
  + Follows standard
  - Naming convention
    - Follows standard
  - Comments
    - Looks good
  - General code quality
    - API calls are correct and data work as expected
addNewView.js
- Indentation/code styling
  + Follows standard
  - Naming convention
    - Follows standard
  - Comments
    - Looks good
  - General code quality
    - Replaced hardcoded values with dynamic current date

What needs to be done

No issues found

Conclusion

Works as intended and the code is ready to be merged.

# Review on #747 ## Whats done ### Tested on macOS using Chrome + App starts + Checked that temperature data for year and month is displayed correctly. + Verified API calls use correct endpoints `/api/temperature/{year}` and `/api/temperature/{year}/{month}` ### Inspected following files + TemperatureMonthView.js + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Looks good + General code quality + Work as expected + TemperatureYearView.js + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Looks good + General code quality + No issues found + useTemperatureByMonth.js + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Looks good + General code quality + API calls are correct and month values work as expected + useTemperatureByYear.js + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Looks good + General code quality + API calls are correct and data work as expected + addNewView.js + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Looks good + General code quality + Replaced hardcoded values with dynamic current date ## What needs to be done + No issues found ## Conclusion + Works as intended and the code is ready to be merged.

a22erigr merged commit be0c34e938 into team_2_week_4

2026-05-05 14:11:53 +00:00

a22erigr referenced this pull request from a commit

2026-05-05 14:11:55 +00:00

Merge pull request 'fix frontend connection for temperature year and month endpoints' (#747) from 722-fix-year-month-api-connection into team_2_week_4

c24danli changed title from ~~fix frontend connection for temperature year and month endpoints~~ to 722-fix frontend connection for temperature year and month endpoints

2026-05-06 07:11:37 +00:00

b25marem referenced this pull request

2026-05-06 08:09:19 +00:00

We need to fix the frontend connection to Average temperature year and Average temperature year month #722

a22erigr referenced this pull request

2026-05-06 08:13:13 +00:00

We need to fix the frontend connection to Average temperature year and Average temperature year month #722

~~j21marbr referenced this pull request 2026-05-07 10:43:17 +00:00~~

#768 bugfix 404 error briefly shown #805

b25marem referenced this pull request from a commit

2026-05-15 08:56:03 +00:00

Merge pull request 'fix frontend connection for temperature year and month endpoints' (#747) from 722-fix-year-month-api-connection into team_2_week_4