743-fix-position-logo-phone #750

Merged
a24julot merged 3 commits from 743-fix-position-logo-phone into team_1_week_4 2026-05-05 13:26:29 +00:00
Collaborator

When "transition" to screen-size less than 768px the b logo is shown and is positioned to the left side.

Also added the feature of menu sliding in from the left, it stopped working on earlier changes.

When "transition" to screen-size less than 768px the b logo is shown and is positioned to the left side. Also added the feature of menu sliding in from the left, it stopped working on earlier changes.
now when center logo is viewed in smaller "screens" than 768px it will display the "b" logo on the left side. If it is bigger the original logo is displayed.
This was an earlier feature that did not work after my previous changes to the menu, did not work with "display block".
Collaborator

Review on #750

What has been Done.

Reviewed code and test so that the logo moves to the left.

Tested on Windows Using Firefox with the inspection tool to change the size.

  • App starts
  • The logo is on the left side.
  • The logo can be interacted with.

Inspected the following files "HamburgerMenu.module.css and Navbar.module.css

  • the css seems to be good (asides from the known issues)

What needs to be done

  • Nothing

Conclusion

In conclusion the structure looks correct and behaves as expected aside from the known issues this implementation seems to have fixed the issue and can be merged.

### Review on #750 ### What has been Done. Reviewed code and test so that the logo moves to the left. ### Tested on Windows Using Firefox with the inspection tool to change the size. - App starts - The logo is on the left side. - The logo can be interacted with. ### Inspected the following files "HamburgerMenu.module.css and Navbar.module.css - the css seems to be good (asides from the known issues) ### What needs to be done - Nothing ### Conclusion In conclusion the structure looks correct and behaves as expected aside from the known issues this implementation seems to have fixed the issue and can be merged.
a24julot merged commit fcc79310e6 into team_1_week_4 2026-05-05 13:26:29 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!750
No description provided.