Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

Update starting-sizes for all views #784

Merged
a24julot merged 3 commits from #778-default-card-sizes into team_1_week_5 2026-05-08 07:39:27 +00:00
Conversation 2 Commits 3 Files changed 2 +74 -24
b24hugst commented 2026-05-06 12:40:38 +00:00
Collaborator
Copy link

All views now have a more proportional starting size, following #771 conclusion.

Issue: #778

All views now have a more proportional starting size, following #771 conclusion. Issue: #778
a24julot 2026-05-07 08:59:53 +00:00
a24hamrh commented 2026-05-07 10:24:02 +00:00
Collaborator
Copy link

Review on #784

Whats done

Tested on Windows 11 using Firefox

  • App starts
    • Added all the different views and compared there sizes to #771.

Inspected following files: viewConfig.js and AddNewView.js

  • Both files
    • Indentation/code styling
      • Indentation is ok
    • Naming convention
      • Naming convention is followed
    • Comments
      • There is no comments at all. More comments would be nice
    • General code quality
      • The general code quality is good

What needs to be done

  • viewConfig.js
    • More comments

Conclusion

  • The code looks good and the implementation solves the issue. Only thing i noticed are a lack of comments.
# Review on #784 ## Whats done ### Tested on Windows 11 using Firefox + App starts + Added all the different views and compared there sizes to #771. ### Inspected following files: viewConfig.js and AddNewView.js + Both files + Indentation/code styling + Indentation is ok + Naming convention + Naming convention is followed + Comments + There is no comments at all. More comments would be nice + General code quality + The general code quality is good ## What needs to be done + viewConfig.js + More comments ## Conclusion + The code looks good and the implementation solves the issue. Only thing i noticed are a lack of comments.
a24hamrh commented 2026-05-08 07:19:54 +00:00
Collaborator
Copy link

Comments looks good now.

Comments looks good now.
a24julot merged commit da7dc8c9fb into team_1_week_5 2026-05-08 07:39:27 +00:00
c24danli deleted branch #778-default-card-sizes 2026-05-21 13:57:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
a24hamrh
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!784
No description provided.