Update starting-sizes for all views #784

Merged

a24julot merged 3 commits from #778-default-card-sizes into team_1_week_5

2026-05-08 07:39:27 +00:00

b24hugst commented

2026-05-06 12:40:38 +00:00

Collaborator

All views now have a more proportional starting size, following #771 conclusion.

Issue: #778

All views now have a more proportional starting size, following #771 conclusion. Issue: #778

b24hugst added 1 commit

2026-05-06 12:40:39 +00:00

Update starting-sizes for all cards eba7f1157a

b24hugst added the

needs review

label

2026-05-06 13:27:47 +00:00

a24julot

2026-05-07 08:59:53 +00:00

added
Under-review
and removed
needs review
labels
requested review from a24hamrh

a24hamrh commented

2026-05-07 10:24:02 +00:00

Collaborator

Review on #784

Whats done

Tested on Windows 11 using Firefox

App starts
- Added all the different views and compared there sizes to #771.

Inspected following files: viewConfig.js and AddNewView.js

Both files
- Indentation/code styling
  - Indentation is ok
- Naming convention
  - Naming convention is followed
- Comments
  - There is no comments at all. More comments would be nice
- General code quality
  - The general code quality is good

What needs to be done

viewConfig.js
- More comments

Conclusion

The code looks good and the implementation solves the issue. Only thing i noticed are a lack of comments.

# Review on #784 ## Whats done ### Tested on Windows 11 using Firefox + App starts + Added all the different views and compared there sizes to #771. ### Inspected following files: viewConfig.js and AddNewView.js + Both files + Indentation/code styling + Indentation is ok + Naming convention + Naming convention is followed + Comments + There is no comments at all. More comments would be nice + General code quality + The general code quality is good ## What needs to be done + viewConfig.js + More comments ## Conclusion + The code looks good and the implementation solves the issue. Only thing i noticed are a lack of comments.