Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

#900-logger-for-middleware #918

Merged
a22erigr merged 3 commits from #900-logger-for-middleware into team_2_week_5 2026-05-13 07:33:45 +00:00
Conversation 3 Commits 3 Files changed 2 +21 -18
j21marbr commented 2026-05-12 11:24:34 +00:00
Collaborator
Copy link

Changes:

  • Replace Console.WriteLine with ILogger
  • Added information, warning and error logs
Changes: - Replace Console.WriteLine with ILogger - Added information, warning and error logs
j21marbr commented 2026-05-12 11:46:33 +00:00
Author
Collaborator
Copy link
No description provided.
bild.png
238 KiB
bild.png
b23albst approved these changes 2026-05-13 07:18:25 +00:00
b23albst left a comment
Collaborator
Copy link

Review on #918

Whats done

Tested that the logs were correctly output and that nothing else was affected

Tested on ubuntu

  • The middleware container runs like it is supposed to and its logs can be read
  • I don't know if it was of concern, but the app starts like normal as well

Inspected following files

  • middleware/middleware/Program.cs
    • Indentation/code styling
      • Indentation is ok
    • Comments
      • No comments added, but they are not needed in this context, so I think this is fine.
    • General code quality
      • Appropriate categories (warning, error, etc.) for the logs
      • The LogError on on line 75 does not follow the same convention as the others. It just logs the exception message. I'm not sure, since I did not get any exceptions, but I think writing the logs like others (logger.LogError(e, ....)) Outputs the stack trace as well as the exception message, which I think is preferable.

What needs to be done

  • Program.cs line 75
    • I think the logger should follow the same convention as the other error logs.

Conclusion

  • I won't reject the pr, since it is such a small error, and it's just a matter of opinion, but I still think it should be changed.
  • Other than that, this is totally ready to be merged.
# Review on #918 ## Whats done Tested that the logs were correctly output and that nothing else was affected ### Tested on ubuntu + The middleware container runs like it is supposed to and its logs can be read + I don't know if it was of concern, but the app starts like normal as well ### Inspected following files + middleware/middleware/Program.cs + Indentation/code styling + Indentation is ok + Comments + No comments added, but they are not needed in this context, so I think this is fine. + General code quality + Appropriate categories (warning, error, etc.) for the logs + The LogError on on line 75 does not follow the same convention as the others. It just logs the exception message. I'm not sure, since I did not get any exceptions, but I think writing the logs like others (logger.LogError(e, ....)) Outputs the stack trace as well as the exception message, which I think is preferable. ## What needs to be done + Program.cs line 75 + I think the logger should follow the same convention as the other error logs. ## Conclusion + I won't reject the pr, since it is such a small error, and it's just a matter of opinion, but I still think it should be changed. + Other than that, this is totally ready to be merged.
a22erigr merged commit 7a7fbc81e4 into team_2_week_5 2026-05-13 07:33:45 +00:00
a24sakma commented 2026-05-20 09:58:02 +00:00
Collaborator
Copy link

This pr needs be reopened as the changes was removed from last week due to issues.

Just make sure you branch is up to date and you re-base with latest changes

This pr needs be reopened as the changes was removed from last week due to issues. Just make sure you branch is up to date and you re-base with latest changes
Sign in to join this conversation.
Reviewers
No reviewers
b23albst
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!918
No description provided.