Buttons (month, year) do not work in mobile #938
Labels
No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
No milestone
No project
5 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Andras/BoundlessFlowCampus2K#938
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Buttons in TemperatureMonthView and TemperatureYearView do not work as intended in mobile view.
Is this issue identified by connecting with an actual mobile device or using responsive mode on a desktop web browser?
@b24johka wrote in #938 (comment):
On a desktop web browser.
I would like to further imply that the original temperature view doesn't seem to work either, Clockview toggle button does not respond to touch events and neither does SMHI forecast view.
Maybe it would be appropriate to change this issue to focus on fixing all of the views? chances are big that its the same core issue for all of them.
Map view doesnt respond well either.
I tested this on chrome just switching to phone in device toolbar. I noticed the buttons don't work when in edit mode, but they work for me here when outside of edit mode. Although I don't know how accurate this chrome toolbar thingy is.
Sure, you can change to title @b24johka . But if you want, I can make separate issues for the views, but do whatever suits you!
Spent alot of time trying to understand the problem without any success, apperantly this has been an issue all the way back to team_1_week_3. Like mentioned above it is only a problem when in edit mode.
It super weird how its only a problem on phones, i tried removing all of the responsive CSS and nothing changed.
Right now, my bet is that somehow the react grid layout is stealing all pointer events from the buttons.
Its also worth mentioning that the buttons work in edit mode but only if you double click them, made me suspect that something from the old "Double click to resize" was left in the code.
I will keep searching for whatever is causing this issue, and keep this issue updated.
Since the entire view is draggable, button presses are interpreted as drag attempts to reposition the view. By disabling dragging on the view's buttons, the issue is resolved. This needs to be applied to all views that implement their own buttons.
enableEdit activates dragging through
dragConfig={{ enabled: enableEdit }}, which is why the buttons work normally when edit mode is disabled.Implementation is done, updated all current views with buttons and a pull-request has been made.
Has been merged in pr #990