Andras/BoundlessFlowCampus2K

Fork 0

#305-fileService PR 2.0 #947

Merged

a22erigr merged 17 commits from #305-fileService into team_2_week_6

2026-05-15 12:32:40 +00:00

a24noabe commented

2026-05-13 12:06:34 +00:00

Collaborator

fileService

Created a service to upload and download files to.

Endpoints

Endpoint	Description	Request body
`GET /f/{id}`	Fetch a file	None
`POST /upload/`	Upload a file	Multipart/form-data

Testing

I recommend rebuilding everything before testing.
For testing the /api/files/upload/ endpoint you can either use an HTML file:

<!DOCTYPE html>
<html lang="en">
<body>
    <form action="http://localhost/api/files/upload/" method="post" enctype="multipart/form-data">
        <input type="file" name="image" id="image">
        <button type="submit">Upload</button>
    </form>
</body>
</html>

Or you can use Bruno. In order to use bruno, you must send the upload as a POST request, with the MIME/media type being "multipart/form-data". The image should be sent in the Key/Value field with the key name being "image". Here you can see an example:

In order to view your uploaded file, you use the /api/files/f/{id} endpoint, with the id being the "name" field of the response you get when you upload. Here is what that looks like in a browser:

And in bruno:

Note that in bruno, you must enter the id as a path variable by typing /api/files/f/:id in the url, and then entering the value in the table for path variables. See the example above.

# fileService Created a service to upload and download files to. ## Endpoints | Endpoint | Description | Request body | |---|---|---| | `GET /f/{id}` | Fetch a file | None | | `POST /upload/` | Upload a file | Multipart/form-data | ## Testing I recommend rebuilding everything before testing. For testing the `/api/files/upload/` endpoint you can either use an HTML file: ```HTML <!DOCTYPE html> <html lang="en"> <body> <form action="http://localhost/api/files/upload/" method="post" enctype="multipart/form-data"> <input type="file" name="image" id="image"> <button type="submit">Upload</button> </form> </body> </html> ``` Or you can use Bruno. In order to use bruno, you must send the upload as a POST request, with the MIME/media type being "multipart/form-data". The image should be sent in the Key/Value field with the key name being "image". Here you can see an example: ![image](/attachments/6e10817d-0d28-494c-be26-8ab1242cd5f7) In order to view your uploaded file, you use the `/api/files/f/{id}` endpoint, with the id being the "name" field of the response you get when you upload. Here is what that looks like in a browser: ![image](/attachments/849d5314-f729-47cd-8b12-ffd561b1ad6a) And in bruno: ![image](/attachments/e34765f4-b93e-4a11-9209-bdb32f882717) Note that in bruno, you must enter the id as a path variable by typing `/api/files/f/:id` in the url, and then entering the value in the table for path variables. See the example above.

image.png

57 KiB

image.png

823 KiB

image.png

671 KiB

a24noabe added 15 commits

2026-05-13 12:06:35 +00:00

Start 0fda9ce5df

Ripped straight from tempService.
Nothing done at this point. will get worked on.

More implementing e04add6454

The API endpoints now run, but they don't return images or allow for uploading yet. I've implemented some file validation for the upload to make sure that the files uploaded isn't an exe masquerading as an image file. There is also some debugging code in there but it's commented as such for easy removal. There are improvements to be made

it works 8fd02f2b80

lots of code (unreadable)

did something to fix something e6d6f9d5b0

commented and restructured ed949e82cb

More commenting d84e91818f

Update README.md f93c04d139

directory name change, db connection 9583d9316b

Commenting, standards, and quick fix to method 9e56a8526e

Removed the service from our compose since no auth yet 0d61929861

After fix of merge conflict 6e81f26bcd

Revert "After fix of merge conflict" 09cbbe5973

This reverts commit 6e81f26bcd.

Merge branch 'temp_branch_week_5' into #305-fileService 1acb83a5d7

Cleanup and clarifying b50dc093b9

Added to rebuild scripts, and changed readme 38b789ad1a

a22erigr requested review from b24idalu

2026-05-13 13:18:07 +00:00

a24julot changed target branch from Temp-Main-Week-5 to team_2_week_6

2026-05-13 13:55:29 +00:00

b24idalu requested changes

2026-05-13 16:03:56 +00:00

Dismissed

b24idalu left a comment

Collaborator

Review on #305

Whats done

Implemented a file system.

Tested on Windows using Bruno

App starts
- App works well.
- Tested endpoints through Bruno, works well and does what is intended.

Inspected following files.

DockerCompose/init_sql/04-files.sql
- Naming convention
  - Looks good except for the variable name "file_contenttype" which should probably be "file_content_type"
service/fileService/fileService.Test/UnitTest1.cs & service/fileService/fileService.Test/fileService.Test.csproj
- Code quality
  - There is a blankspace at the start of both files, unsure if we can remove those.
service/fileService/fileService/Services/FileService.cs
- Comments
  - On line 113 there is a comment that has, from what I assume, unnecessary text ("idk dawg")
Rest of the files look awesome.

What needs to be done

The above files should be fixed

Conclusion

It is ready to merge after fixing the comments
Should we create a folder for Bruno stuff? Easier to test endpoints and document

# Review on #305 ## Whats done Implemented a file system. ### Tested on Windows using Bruno + App starts + App works well. + Tested endpoints through Bruno, works well and does what is intended. ### Inspected following files. + DockerCompose/init_sql/04-files.sql + Naming convention + Looks good except for the variable name "file_contenttype" which should probably be "file_content_type" + service/fileService/fileService.Test/UnitTest1.cs & service/fileService/fileService.Test/fileService.Test.csproj + Code quality + There is a blankspace at the start of both files, unsure if we can remove those. + service/fileService/fileService/Services/FileService.cs + Comments + On line 113 there is a comment that has, from what I assume, unnecessary text ("idk dawg") + Rest of the files look awesome. ## What needs to be done + The above files should be fixed ## Conclusion + It is ready to merge after fixing the comments + Should we create a folder for Bruno stuff? Easier to test endpoints and document

a22erigr added 1 commit

2026-05-15 07:28:48 +00:00

Merge branch 'team_2_week_6' into #305-fileService aecbeca958

a24noabe added 1 commit

2026-05-15 10:59:42 +00:00

Changed field name (standard) + removed whitespace 28a7f2b7a3

a24noabe commented

2026-05-15 11:56:10 +00:00

Author

Collaborator

I've removed the comment. I think i misunderstood what you meant by with the blankspace in UnitTest1.cs and fileService.Test.csproj but I removed a blank line in one of them. I'm couldn't find a way to remove the [U+FEFF] so I think we might have to live with it. I also changed file_contenttype to file_content_type in the database and the DatabaseQueries file.

b24idalu approved these changes

2026-05-15 12:13:46 +00:00

b24idalu left a comment

Collaborator

Looks good!

a22erigr merged commit d1f8a47358 into team_2_week_6

2026-05-15 12:32:40 +00:00

a22erigr referenced this pull request from a commit

2026-05-15 12:32:42 +00:00

Merge pull request '#305-fileService PR 2.0' (#947) from #305-fileService into team_2_week_6