1006-update-css-in-frontend-pages #1009
No reviewers
Labels
No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Andras/BoundlessFlowCampus2K!1009
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "1006-update-css-in-frontend-pages"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What’s done:
support.js:
Updated to use bracket notation
NotFound:
Refactored to follow kebab-case naming in CSS modules and bracket notation . Also broke-out several inline styles into the CSS module.
Dashboard:
Updated to use kebab-case CSS class names and bracket notation for CSS modules.
broke-out non-dynamic inline styles into the CSS module where appropriate.
Some inline styles were intentionally ignored, as they depend on runtime calculations such as the grid positioning and layout sizing and cannot be moved to static CSS without issues.
Looked over the css, everything that should have been updated has been and this can be safely merged. Only note is you should rename the pull request to "#1006 update css in frontend pages" so it links back to the original issue.
Shouldn't tool-bar be toolbar as it is written as one word and not two? @b24krila
@b24erika wrote in #1009 (comment):
The changes are done @a24julot.