Implemented login on frontend #1019

Merged

a22erigr merged 1 commit from 991-login-and-signup into team_2_week_6

2026-05-20 07:39:51 +00:00

b23albst commented

2026-05-19 22:34:25 +00:00

Collaborator

This is my current progress on issue #991. The issue also includes signing up, but this is not included in this pr due to time constraints.

A majority of the hook useLogin could be broken out to a utility hook for making post requests. This is something I started on, but abandoned due to time constraints (I prioritized sleep).

The error handeling is kind of crude (just displaying the text received in the response). This is due to the two common errors during login return the same error type...

As this is in no way perfect, but you can actually log in and receive the JWT access token, so I leave it up to the reviewer/issue coordinator to decide if this can be merged or not. I just thought it would be nice if I could continue work on the up-to-date branch.
NOTE: Since sign up has not been implemented to the frontend yet. A tool like bruno or RESTer can be used to access the SignUp endpoint and create the account.

This is my current progress on issue #991. The issue also includes signing up, but this is not included in this pr due to time constraints. A majority of the hook useLogin could be broken out to a utility hook for making post requests. This is something I started on, but abandoned due to time constraints (I prioritized sleep). The error handeling is kind of crude (just displaying the text received in the response). This is due to the two common errors during login return the same error type... As this is in no way perfect, but you can actually log in and receive the JWT access token, so I leave it up to the reviewer/issue coordinator to decide if this can be merged or not. I just thought it would be nice if I could continue work on the up-to-date branch. NOTE: Since sign up has not been implemented to the frontend yet. A tool like bruno or RESTer can be used to access the SignUp endpoint and create the account.

b23albst added 1 commit

2026-05-19 22:34:26 +00:00

Implemented login on frontend 5e0b35847c

b23albst added the

frontEnd

needs review

labels

2026-05-19 22:38:14 +00:00

a22erigr

2026-05-20 06:03:23 +00:00

added the
Under-review
label
requested review from j21marbr

j21marbr commented

2026-05-20 07:37:51 +00:00

Collaborator

Review on #1019

Whats done

Tested on macOS using Chrome

App starts
Login functionality works through frontend
Login works with valid credentials
Invalid password correctly shows failed login
Verified that a JWT access token is received

Inspected following files

LoginModal.js
- Indentation/code styling
  - Follows standard
- Naming convention
  - Follows standard
- Comments
  - Follows standard
- General code quality
  - No issues found
LoginModal.module.css
- Indentation/code styling
  - Follows standard
- Naming convention
  - Follows standard
- Comments
  - Follows standard
- General code quality
  - No issues found
useLogin.js
- Indentation/code styling
  - Follows standard
- Naming convention
  - Follows standard
- Comments
  - Follows standard
- General code quality
  - No issues found

What needs to be done

Continue implementation of the sign up functionality

Conclusion

The implemented login functionality works correctly and the current changes look ready to be merged for continued work on the updated branch.

# Review on #1019 ## Whats done ### Tested on macOS using Chrome + App starts + Login functionality works through frontend + Login works with valid credentials + Invalid password correctly shows failed login + Verified that a JWT access token is received ### Inspected following files + LoginModal.js + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Follows standard + General code quality + No issues found + LoginModal.module.css + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Follows standard + General code quality + No issues found + useLogin.js + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Follows standard + General code quality + No issues found ## What needs to be done + Continue implementation of the sign up functionality ## Conclusion The implemented login functionality works correctly and the current changes look ready to be merged for continued work on the updated branch.