#1046 Fixed localization in settings. #1050

Merged

a24julot merged 1 commit from #1046-Fix-broken-localization-in-settings into team_1_week_7

2026-05-21 08:12:37 +00:00

f21marfo commented

2026-05-20 12:56:39 +00:00

Collaborator

Fixed the broken localization on the settings page, as described in issue #1046.

f21marfo added the

frontEnd

needs review

labels

2026-05-20 12:56:39 +00:00

f21marfo added 1 commit

2026-05-20 12:56:40 +00:00

Fixed localization in settings. 7bac7002cb

Localization of the seasonal themes and dark mode options were broken post-merge.

Fixed them so that they now use localization keys again.

a22erigr

2026-05-20 13:00:34 +00:00

added the
Under-review
label
requested review from e24aleli

e24aleli commented

2026-05-20 13:30:55 +00:00

Collaborator

Review on issue #1046

Whats done

Reviewed the implementation of dynamic localization strings inside of settings.js dashboard vieww.

Tested on

Windows 11 using Helium browser and ran playwright tests

Chromium
WebKit
IOS
Android

App starts: Yes, the application compiles clean and runs.

Inspected settings.js

indentation is clean, code quality is improved, css is not changed.

Conclusion

Nothing need to be done the problem is fixed and the branch is ready for merge!

# Review on issue #1046 # Whats done Reviewed the implementation of dynamic localization strings inside of `settings.js` dashboard vieww. ## Tested on Windows 11 using Helium browser and ran playwright tests - Chromium - WebKit - IOS - Android ![image](/attachments/d02d4d11-8712-4635-a991-11c9dd67dafd) **App starts:** Yes, the application compiles clean and runs. ## Inspected settings.js indentation is clean, code quality is improved, css is not changed. ## Conclusion Nothing need to be done the problem is fixed and the branch is ready for merge!

image.png

55 KiB