a22erigr commented

Collaborator

The parts that can run in parallel now run in parallel
If you don't want to run in parallel use the script UnixRebuildDebug.
This script copies but removes the code that makes it run in parallel.
Ensuring it is always up to date.
The Script was tested and compared using the comparison Script. Here are the results

+ The parts that can run in parallel now run in parallel + If you don't want to run in parallel use the script UnixRebuildDebug. This script copies but removes the code that makes it run in parallel. Ensuring it is always up to date. + The Script was tested and compared using the comparison Script. Here are the results ![bild](/attachments/6b2f0718-5216-4e7c-a4b5-8d934dfbe53d)

bild.png

36 KiB

a22erigr added the

needs review

label

2026-05-20 13:56:50 +00:00

a22erigr added 1 commit

2026-05-20 13:56:51 +00:00

updated the UnitRebuild-script to make it run in parallel 1d9a0a49c9

+ The parts that can run in parallel now run in parallel
+ If you don't want to run in parallel use the script UnixRebuildDebug.
  This script copies but removes the code that makes it run in parallel.
Ensuring it is always up to date.

b24johka commented

2026-05-20 17:13:15 +00:00

Collaborator

I am unsure if this script removes orphanes (Containers that are not in the compose.yaml file but left from earlier builds), this might be fixed with the new version of the rebuild script that stops and removes old containers though, and might not be an issue.

a22erigr commented

2026-05-21 08:32:40 +00:00

Author

Collaborator

@b24johka wrote in #1056 (comment):

I am unsure if this script removes orphanes (Containers that are not in the compose.yaml file but left from earlier builds), this might be fixed with the new version of the rebuild script that stops and removes old containers though, and might not be an issue.

I don't think this feature was implemented when we created the team branches. Personalty i am a bit unsure on how to implement your request. It would be lowly if you were so kind as to provide me with the command so that I may update the script. Best regards @a22erigr

@b24johka wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/1056#issuecomment-12369: > I am unsure if this script removes orphanes (Containers that are not in the compose.yaml file but left from earlier builds), this might be fixed with the new version of the rebuild script that stops and removes old containers though, and might not be an issue. I don't think this feature was implemented when we created the team branches. Personalty i am a bit unsure on how to implement your request. It would be lowly if you were so kind as to provide me with the command so that I may update the script. Best regards @a22erigr

a22erigr requested review from j21marbr

2026-05-21 08:47:37 +00:00

j21marbr commented

2026-05-21 10:26:57 +00:00

Collaborator

Review on #1056

Whats done

Tested on macOS using Chrome

App starts
- Ran UnixRebuild.sh and UnixRebuildDebug.sh
- Verified that containers started
- Verified that the app starts correctly

Inspected following files

UnixRebuild.sh
- Indentation/code styling
  - Follows standard
- Naming convention
  - Follows standard
- Comments
  - Looks good
- General code quality
  - No issues found, parallel execution setup looks correct
UnixRebuildDebug.sh
- Indentation/code styling
  - Follows standard
- Naming convention
  - Follows standard
- Comments
  - Looks good, comments are clear
  - Just a small typo, scipt should be script
- General code quality
  - No issues found

What needs to be done

Fix typo in UnixRebuildDebug comment

Conclusion

Works as intended and the code is ready to be merged after the small fix.

# Review on #1056 ## Whats done ### Tested on macOS using Chrome + App starts + Ran `UnixRebuild.sh` and `UnixRebuildDebug.sh` + Verified that containers started + Verified that the app starts correctly ### Inspected following files + UnixRebuild.sh + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Looks good + General code quality + No issues found, parallel execution setup looks correct + UnixRebuildDebug.sh + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Looks good, comments are clear + Just a small typo, `scipt` should be `script` + General code quality + No issues found ## What needs to be done + Fix typo in UnixRebuildDebug comment ## Conclusion + Works as intended and the code is ready to be merged after the small fix.