#1047 fonts more uniform #1063

Merged

a22erigr merged 1 commit from #1047-fonts-uniform-in-views into team_2_week_7

2026-05-21 09:51:51 +00:00

b24idalu commented

2026-05-21 07:50:56 +00:00

Collaborator

Problem: Cards use different font-sizes and some do not properly show.

Solution: Changed font size to "2rem" and centered some of the texts.

Could be a good idea to set guidelines on which sizes should be used for different types of texts.

Problem: Cards use different font-sizes and some do not properly show. Solution: Changed font size to "2rem" and centered some of the texts. Could be a good idea to set guidelines on which sizes should be used for different types of texts.

b24idalu added 1 commit

2026-05-21 07:50:57 +00:00

More uniform texts eb4559e0fb

More uniform texts

b24idalu self-assigned this

2026-05-21 07:51:03 +00:00

b24idalu added the

frontEnd

needs review

labels

2026-05-21 07:51:36 +00:00

a22erigr

2026-05-21 09:24:15 +00:00

added the
Under-review
label
requested review from c24carso

c24carso commented

2026-05-21 09:49:15 +00:00

Collaborator

Review on #1047

What's done

Tested on Windows using Firefox

App starts
- No issues found
Tested temperature views, font sizes now consistent
Tested energy views, same

Inspected following files

frontend/src/features/energy/all/EnergyAllView.module.css
- Indentation/code styling
  - Indentation is ok
- CSS standard
  - follows wiki standard
- Comments
  - Existing comments are fine
frontend/src/features/energy/sensor/EnergyView.js
- Naming convention
  - follows wiki standards
- General code quality
  - Looks good
frontend/src/features/energy/sensor/EnergyView.module.css
- CSS standard
  - Looks good
- Comments
  - Looks good
frontend/src/features/temperature/default/TemperatureView.module.css
- CSS standard
  - Looks good
- Comments
  - Existing comment still accurate
frontend/src/features/temperature/month/TemperatureMonthView.module.css
- CSS standard
  - more consistent
frontend/src/features/temperature/year/TemperatureYearView.module.css
- CSS standard
  - same as month view

Conclusion

Good cleanup that makes font sizes consistent across views. Ready to merge.

# Review on #1047 ## What's done ### Tested on Windows using Firefox + App starts + No issues found + Tested temperature views, font sizes now consistent + Tested energy views, same ### Inspected following files + frontend/src/features/energy/all/EnergyAllView.module.css + Indentation/code styling + Indentation is ok + CSS standard + follows wiki standard + Comments + Existing comments are fine + frontend/src/features/energy/sensor/EnergyView.js + Naming convention + follows wiki standards + General code quality + Looks good + frontend/src/features/energy/sensor/EnergyView.module.css + CSS standard + Looks good + Comments + Looks good + frontend/src/features/temperature/default/TemperatureView.module.css + CSS standard + Looks good + Comments + Existing comment still accurate + frontend/src/features/temperature/month/TemperatureMonthView.module.css + CSS standard + more consistent + frontend/src/features/temperature/year/TemperatureYearView.module.css + CSS standard + same as month view ## Conclusion + Good cleanup that makes font sizes consistent across views. Ready to merge.