Andras/BoundlessFlowCampus2K
3
6
Fork 0
Code Issues 144 Pull requests 13 Projects Releases Packages Wiki Activity Actions 2

#1030-landscape-view-bug #1066

Merged
a22erigr merged 2 commits from #1030-landscape-view-bug into team_2_week_7 2026-05-21 09:24:58 +00:00
Conversation 3 Commits 2 Files changed 1 +6
j21marbr commented 2026-05-21 08:04:23 +00:00
Collaborator
Copy link

Fixed layout issues in AddCardModal landscape mode.

Tested on iphone using safari in landscape mode.

Fixed layout issues in AddCardModal landscape mode. Tested on iphone using safari in landscape mode.
j21marbr commented 2026-05-21 08:07:10 +00:00
Author
Collaborator
Copy link
No description provided.
bild.PNG
168 KiB
bild1.PNG
153 KiB
bild.PNG bild1.PNG
a22erigr 2026-05-21 08:28:47 +00:00
c24carso commented 2026-05-21 09:02:50 +00:00
Collaborator
Copy link

Review on #1030

What's done

Tested on Windows using Firefox and responsive mode

  • App starts
    • No issues found
  • Tested Add Card modal in portrait mode, displays correctly with list stacking above preview
  • Tested Add Card modal in desktop landscape, list and preview sit side by side
  • Tested Add Card modal in iPhone portrait using Firefox responsive mode, modal looks correct
  • Tested Add Card modal in iPhone landscape using Firefox responsive mode, looks correct

Inspected following files

  • frontend/src/features/addCardModal/AddCardModal.module.css
    • Indentation/code styling
      • Indentation is ok
    • CSS standard
      • Uses kebab-case class name .view-list, follows wiki standards
      • Properties are in alphabetical order, follows wiki standard
    • Naming convention
      • .view-list follows kebab-case convention
    • Comments
      • Missing comment
    • General code quality
      • Clean and minimal

What needs to be done

  • Add a comment for css

Conclusion

  • Minor css fix before it's ready to merge.
# Review on #1030 ## What's done ### Tested on Windows using Firefox and responsive mode + App starts + No issues found + Tested Add Card modal in portrait mode, displays correctly with list stacking above preview + Tested Add Card modal in desktop landscape, list and preview sit side by side + Tested Add Card modal in iPhone portrait using Firefox responsive mode, modal looks correct + Tested Add Card modal in iPhone landscape using Firefox responsive mode, looks correct ### Inspected following files + frontend/src/features/addCardModal/AddCardModal.module.css + Indentation/code styling + Indentation is ok + CSS standard + Uses kebab-case class name .view-list, follows wiki standards + Properties are in alphabetical order, follows wiki standard + Naming convention + .view-list follows kebab-case convention + Comments + Missing comment + General code quality + Clean and minimal ## What needs to be done + Add a comment for css ## Conclusion + Minor css fix before it's ready to merge.
c24carso commented 2026-05-21 09:12:21 +00:00
Collaborator
Copy link

Ready to merge.

Ready to merge.
c24carso approved these changes 2026-05-21 09:13:17 +00:00
a22erigr merged commit 33fb50cdfd into team_2_week_7 2026-05-21 09:24:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
c24carso
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked-waiting-for-further-changes

   
bug

Something is not working

  
bug-only-on-server-for-mobile-not-webpage

   
Bug-Report-After-Merge

   
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
further-changes-needed

   
future-problem-not-fixint-this-period

   
help wanted

Need some help

  
invalid

Something is wrong

  
last-week-issue-to-fix

   
library

   
low-priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
not-implemented.

   
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
Script

   
security

use this for security-related issues

  
SQL

  
style

   
Team 1

Team 1 is responsible for this issue

  
Team 2

Team 2 is responsible for this issue

  
team leaders

   
test-creation

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
unassigned

   
Under-review

   
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!1066
No description provided.