991-frontend-sign-up #1095

Merged

a22erigr merged 5 commits from 991-frontend-sign-up into team_2_week_7

2026-05-22 12:38:11 +00:00

b23albst commented

2026-05-21 13:58:56 +00:00

Collaborator

What's been done

A "second page" has been added to the login modal for sign up
- This is done by setting display to none for the login content div, and vice versa.
Some checks on sign up inputs, such as password length
Sign up functionality

Continued work

For both login and signup, most of the error messages are the text directly from the responses from the post requests, which means they are not localized. This could be handled by matching the returned text and displaying localized, clearer error messages.
Currently, when creating an account, the user only has to input their password once. To avoid accidents, the password should be input twice, and both inputs have to match.

# What's been done + A "second page" has been added to the login modal for sign up + This is done by setting display to none for the login content div, and vice versa. + Some checks on sign up inputs, such as password length + Sign up functionality # Continued work + For both login and signup, most of the error messages are the text directly from the responses from the post requests, which means they are not localized. This could be handled by matching the returned text and displaying localized, clearer error messages. + Currently, when creating an account, the user only has to input their password once. To avoid accidents, the password should be input twice, and both inputs have to match.

b23albst added 4 commits

2026-05-21 13:58:57 +00:00

Added sign up functionality 42a6a11dc1

Added localization for sign up page 63f5107840

First and lastname required for sign up e01469aefa

Added some checks to sign up input e0d48c468c

b23albst added the

needs review

frontEnd

labels

2026-05-21 13:59:07 +00:00

c24danli requested review from j21marbr

2026-05-22 09:21:34 +00:00

j21marbr commented

2026-05-22 11:58:48 +00:00

Collaborator

Review on #1095

Whats done

Tested on macOS using Chrome

App starts
- Tested sign up functionality
  - Sign up page opens correctly
  - Back button works
  - Input fields for username, first and last name, email and password work
- Tested login functionality

Inspected following files

LoginModal.js, LoginModal.module.css, useLogin.js, useSignup.js, en.json, sv.json, AuthService.cs
- Indentation/code styling
  - Follows standard
- Naming convention
  - Follows standard
- Comments
  - Looks good
- General code quality
  - No issues found

What needs to be done

No issues found

Conclusion

Works as intended and the code is ready to be merged

# Review on #1095 ## Whats done ### Tested on macOS using Chrome + App starts + Tested sign up functionality + Sign up page opens correctly + Back button works + Input fields for username, first and last name, email and password work + Tested login functionality ### Inspected following files + LoginModal.js, LoginModal.module.css, useLogin.js, useSignup.js, en.json, sv.json, AuthService.cs + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Looks good + General code quality + No issues found ## What needs to be done + No issues found ## Conclusion + Works as intended and the code is ready to be merged