1110-Cron-job-fix-lost-during-merge #1112

Merged

a22erigr merged 3 commits from 1110-Cron-job-fix-lost-during-merge into team_2_week_7

2026-05-22 14:47:01 +00:00

a24vinla commented

2026-05-22 12:29:02 +00:00

Collaborator

What has been done

Previous PR was lost during merge, I have now readded those fixes. Also removed duplicate setup files

DockerCompose/init_sql/01-sensors.sql
- Removed since setup has been moved to stack
DockerCompose/init_sql/03-sensors.-cron-jobs.sql
- Removed since setup has been moved to stack
DockerCompose/stacks/temperature/init_sql/01-sensors.sql
- We now add the cron extension
- All cron setup has been moved to this file. Having a separate file for cron setup does not make much sense when we have separated things into stacks
DockerCompose/stacks/temperature/init_sql/03-sensors-cron-jobs.sql
- Has been removed as the separation only was necessary when all SQL-init files were bunched together.
- It also seemed to run before the above file sometimes, causing problems

I don't think that the scripts functionality needs to be tested, as it has been tested during two different PR's already.
To check that the cron job gets scheduled, use rebuild script, then enter temperature database container and enter sensors database with the command:
psql -U *username found in env* -d sensors;
then check that the job is scheduled with the command:
SELECT * FROM cron.jobs;

## What has been done Previous PR was lost during merge, I have now readded those fixes. Also removed duplicate setup files + DockerCompose/init_sql/01-sensors.sql + Removed since setup has been moved to stack + DockerCompose/init_sql/03-sensors.-cron-jobs.sql + Removed since setup has been moved to stack + DockerCompose/stacks/temperature/init_sql/01-sensors.sql + We now add the cron extension + All cron setup has been moved to this file. Having a separate file for cron setup does not make much sense when we have separated things into stacks + DockerCompose/stacks/temperature/init_sql/03-sensors-cron-jobs.sql + Has been removed as the separation only was necessary when all SQL-init files were bunched together. + It also seemed to run before the above file sometimes, causing problems I don't think that the scripts functionality needs to be tested, as it has been tested during two different PR's already. To check that the cron job gets scheduled, use rebuild script, then enter temperature database container and enter sensors database with the command: `psql -U *username found in env* -d sensors;` then check that the job is scheduled with the command: `SELECT * FROM cron.jobs;`

a24vinla added the

needs review

label

2026-05-22 12:29:02 +00:00

a24vinla added 3 commits

2026-05-22 12:29:03 +00:00

Removed init sql files that are not part of stack 644f8ebd7a

Readded cron setup to sensors stack 898e800b5b

Sometimes this sql file would run before the other, resulting in errors, moved everything to other file 3ec07b4dc2

a22erigr requested review from a24danwe

2026-05-22 12:39:11 +00:00

a24danwe commented

2026-05-22 14:41:56 +00:00

Collaborator

Review on #1112

Whats done

Reviewed cron job fix.

Tested on macOS using Chrome

Verified duplicate init SQL files were removed.
Verified cron setup was moved into 01-sensors.sql.

Inspected following files

DockerCompose/stacks/temperature/init_sql/01-sensors.sql
- Indentation/code styling
  - Follows standard
- Naming convention
  - Follows standard
- Comments
  - Follows standard
- General code quality
  - Good

What needs to be done

Nothing

Conclusion

Ready to be merged

# Review on #1112 ## Whats done + Reviewed cron job fix. ### Tested on macOS using Chrome + Verified duplicate init SQL files were removed. + Verified cron setup was moved into 01-sensors.sql. ### Inspected following files + DockerCompose/stacks/temperature/init_sql/01-sensors.sql + Indentation/code styling + Follows standard + Naming convention + Follows standard + Comments + Follows standard + General code quality + Good ## What needs to be done + Nothing ## Conclusion + Ready to be merged