Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

Moved items from preview up, but as mentioned before please choose which looks "better". Original, pushed to top or my design #1129

Merged
a24julot merged 2 commits from Move-header-in-preview-up into team_1_week_7 2026-05-25 11:51:17 +00:00
Conversation 9 Commits 2 Files changed 1 +4
e24aleli commented 2026-05-25 08:55:30 +00:00
Collaborator
Copy link
No description provided.
a24julot commented 2026-05-25 08:56:37 +00:00
Collaborator
Copy link

Can you provide us with pictures in this pull request?

Can you provide us with pictures in this pull request?
e24aleli commented 2026-05-25 08:58:43 +00:00
Author
Collaborator
Copy link

Original

image

Pushed up

image

Redesign, subject to change.

image

## Original ![image](/attachments/07e7bf60-1b81-4020-8fba-ffb6e51ffa04) ## Pushed up ![image](/attachments/20939295-67cb-41aa-8d63-40995366a8a6) ## Redesign, subject to change. ![image](/attachments/bc5f98c2-6c6b-40c3-a84e-8c54d32e8d67)
image.png
64 KiB
image.png
953 KiB
image.png
1,017 KiB
a24julot commented 2026-05-25 09:02:47 +00:00
Collaborator
Copy link

"Cancel" and "Add" should not be changed, and the view should still be in the center

"Cancel" and "Add" should not be changed, and the view should still be in the center
👍 1
e24aleli commented 2026-05-25 09:05:55 +00:00
Author
Collaborator
Copy link

Yes, so we keep it as it originally was?

Yes, so we keep it as it originally was?
a24julot commented 2026-05-25 09:11:23 +00:00
Collaborator
Copy link

The issue was to move up the preview text, so that is all that should be done

The issue was to move up the preview text, so that is all that should be done
a22erigr commented 2026-05-25 09:12:40 +00:00
Collaborator
Copy link

I would like if the card is in the center of the "window"

I would like if the card is in the center of the "window"
👍 1
e24aleli commented 2026-05-25 09:57:59 +00:00
Author
Collaborator
Copy link

thats my fault i misunderstood the issue, i have updated the PR so that only the text is positioned on top. However worth noting from what i have seen the text disappears in compact/mobile view but i dont know if thats just on my end.

thats my fault i misunderstood the issue, i have updated the PR so that only the text is positioned on top. However worth noting from what i have seen the text disappears in compact/mobile view but i dont know if thats just on my end.
b24jonel commented 2026-05-25 11:44:42 +00:00
Collaborator
Copy link

Review

Everything works as intended and the code looks good, this can be merged.

### Review Everything works as intended and the code looks good, this can be merged.
a24julot commented 2026-05-25 11:51:07 +00:00
Collaborator
Copy link

@e24aleli wrote in #1129 (comment):

thats my fault i misunderstood the issue, i have updated the PR so that only the text is positioned on top. However worth noting from what i have seen the text disappears in compact/mobile view but i dont know if thats just on my end.

This is okay, I think that we will probably keep it that way to enable more space for the card in the preview space.

@e24aleli wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/1129#issuecomment-13727: > thats my fault i misunderstood the issue, i have updated the PR so that only the text is positioned on top. However worth noting from what i have seen the text disappears in compact/mobile view but i dont know if thats just on my end. This is okay, I think that we will probably keep it that way to enable more space for the card in the preview space.
a24julot merged commit b475215f85 into team_1_week_7 2026-05-25 11:51:17 +00:00
c24danli deleted branch Move-header-in-preview-up 2026-05-28 08:31:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
b24jonel
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!1129
No description provided.