1107-spring-color-theme #1141

Merged
a24julot merged 8 commits from 1107-spring-color-theme into team_1_week_7 2026-05-25 13:10:33 +00:00
Collaborator

What has changed

  • Added colors for the spring theme in theme.css.

  • Changed multiple css files to follow theme variables.

  • Navbar (image).

    • To scale with size, not get stretched.
    • Added display non so that no error image will be displayed in different browsers (when theme not set).
  • Settings.

    • Added div so that settings use full size of browser.
    • Remove padding and added theme.css color.
## What has changed - Added colors for the spring theme in theme.css. - Changed multiple css files to follow theme variables. - Navbar (image). - To scale with size, not get stretched. - Added display non so that no error image will be displayed in different browsers (when theme not set). - Settings. - Added div so that settings use full size of browser. - Remove padding and added theme.css color.
a24julot 2026-05-25 11:46:42 +00:00
Collaborator

Review on #1107

Whats done

Tested on Windows 11 using Google Chrome

  • App starts
    • Tested if every page kept the theme. They do.

Inspected following files theme.css, Navbar.js, Navbar.module.css, Dashboard.module.css, Settings.js, Settings.module.css, ToggleButton.module.css, AddCardModal.module.css and Support.module.css

  • theme.css
    • Indentation/code styling
      • Indentation is ok.
    • CSS standard
      • Follows standards.
    • General code quality
      • Code quality is good.
  • Navbar.js
    • Indentation/code styling
      • Indentation is ok.
    • General code quality
      • Code quality is good.
  • Navbar.module.css
    • Indentation/code styling
      • Indentation is ok.
    • CSS standard
      • Follows the standards.
    • General code quality
      • Code quality is good.
  • Dashboard.module.css
    • Indentation/code styling
      • Indentation is ok.
    • CSS standard
      • Follows the standard.
    • General code quality
      • Code quality is good.
  • Settings.js
    • Indentation/code styling
      • Indentation is ok.
    • General code quality
      • Code quality is good.
  • Settings.module.css
    • Indentation/code styling
      • Indentation is ok.
    • CSS standard
      • Follows the standards.
    • General code quality
      • Code quality is good.
  • ToggleButton.module.css
    • Indentation/code styling
      • Indentation is ok.
    • CSS standard
      • Follows the standards.
    • General code quality
      • Code quality is good.
  • AddCardModal.module.css
    • Indentation/code styling
      • Indentation is ok.
    • CSS standard
      • Follows the standards.
    • General code quality
      • Code quality is good.
  • Support.module.css
    • Indentation/code styling
      • Indentation is ok.
    • CSS standard
      • Follows the standards.
    • General code quality
      • Code quality is good.

Conclusion

  • The spring theme works, the code follows our standards and is ready to be merged.
# Review on #1107 ## Whats done ### Tested on Windows 11 using Google Chrome + App starts + Tested if every page kept the theme. They do. ### Inspected following files theme.css, Navbar.js, Navbar.module.css, Dashboard.module.css, Settings.js, Settings.module.css, ToggleButton.module.css, AddCardModal.module.css and Support.module.css + theme.css + Indentation/code styling + Indentation is ok. + CSS standard + Follows standards. + General code quality + Code quality is good. + Navbar.js + Indentation/code styling + Indentation is ok. + General code quality + Code quality is good. + Navbar.module.css + Indentation/code styling + Indentation is ok. + CSS standard + Follows the standards. + General code quality + Code quality is good. + Dashboard.module.css + Indentation/code styling + Indentation is ok. + CSS standard + Follows the standard. + General code quality + Code quality is good. + Settings.js + Indentation/code styling + Indentation is ok. + General code quality + Code quality is good. + Settings.module.css + Indentation/code styling + Indentation is ok. + CSS standard + Follows the standards. + General code quality + Code quality is good. + ToggleButton.module.css + Indentation/code styling + Indentation is ok. + CSS standard + Follows the standards. + General code quality + Code quality is good. + AddCardModal.module.css + Indentation/code styling + Indentation is ok. + CSS standard + Follows the standards. + General code quality + Code quality is good. + Support.module.css + Indentation/code styling + Indentation is ok. + CSS standard + Follows the standards. + General code quality + Code quality is good. ## Conclusion + The spring theme works, the code follows our standards and is ready to be merged.
a24julot merged commit 82375fc043 into team_1_week_7 2026-05-25 13:10:33 +00:00
c24danli deleted branch 1107-spring-color-theme 2026-05-28 08:30:23 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!1141
No description provided.