1157-fix-responsive-interaction-phone #1172
No reviewers
Labels
No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Andras/BoundlessFlowCampus2K!1172
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "1157-fix-responsive-phone"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What has changed
Added no-drag to ClockView, HistoryView, ScheduleView, TextView and TranslatorView to fix buttons/text inputs to work in "mobile-mode".
Related issues: #1157, #1158, #1159, #1160 and #1162.
Keeping the pull-request open for further view changes.
WIP: 1157-fix-responsive-phoneto WIP: 1157-fix-responsive-interaction-phoneWhat has changed:
Added no drag for VästrafikView and To do list, Sudoku view has also got responsive design so now its fits the screen on mobile.
Related issues: #1170, #1166, #1168
WIP: 1157-fix-responsive-interaction-phoneto 1157-fix-responsive-interaction-phoneThis should be ready for review
Could you test the text input on your iphone? I am curious if the fix completely removed zoom.
@b24johka wrote in #1172 (comment):
Tested on Firefox using the phone agent.
Tested every view for "dragability" and everything seems to be in order. Scrolls inside views are completely paused during edit mode and is resumed when not in edit mode. It would be nice if @b24johka could test on his iPhone as it seems to have some special interactions.
I tested on my Iphone and the zoom in when entering input is completely removed, good job!
Since this is reviewed with the last thing being the zoom in issue, i will suggest this gets merged right away.