Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

changed from dynamic to static string #1178

Merged
a22erigr merged 3 commits from remove-x-Building-from-title into both_teams_week_8 2026-05-27 07:46:01 +00:00
Conversation 1 Commits 3 Files changed 1 +1 -1
e24aleli commented 2026-05-26 12:02:49 +00:00
Collaborator
Copy link

So that the building does not appear in title since it already is in the view

So that the building does not appear in title since it already is in the view
a24julot changed target branch from team_1_week_7 to both_teams_week_8 2026-05-26 12:09:45 +00:00
c24elipe approved these changes 2026-05-27 07:45:20 +00:00
c24elipe left a comment
Collaborator
Copy link

Review on PR #1178

image
It works; nothing breaks.

Tested on an Arch-based Linux distribution, and Librewolf (Firefox)

  • It compiles and works.

Inspected the following files

  • frontend/src/features/temperature/default/TemperatureView.js
    • Indentation/code styling
      • Small style problem. According to prettier," should be '. I have changed this using prettier.
    • Naming convention
      • They are followed.
    • Comments
      • Not needed.
    • General code quality
      • Nothing to complain about.

What needs to be done

Nothing

Conclusion

It can be merged.

# Review on PR #1178 ![image](/attachments/028dfa00-53e2-4148-84a1-c2fe97a52b8d) It works; nothing breaks. ## Tested on an Arch-based Linux distribution, and Librewolf (Firefox) * It compiles and works. ## Inspected the following files * **frontend/src/features/temperature/default/TemperatureView.js** * **Indentation/code styling** * Small style problem. According to prettier," should be '. I have changed this using prettier. * **Naming convention** * They are followed. * **Comments** * Not needed. * **General code quality** * Nothing to complain about. # What needs to be done Nothing # Conclusion It can be merged.
image.png
17 KiB
a22erigr merged commit a8ba9122dc into both_teams_week_8 2026-05-27 07:46:01 +00:00
a22erigr deleted branch remove-x-Building-from-title 2026-05-27 07:46:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
c24elipe
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!1178
No description provided.