#1156-button-overflow #1179

Merged
a22erigr merged 3 commits from 1156-button-overflow into both_teams_week_8 2026-05-26 17:55:50 +00:00
Collaborator

Removed the overflow and improved the contrast in dark mode

#1156

Removed the overflow and improved the contrast in dark mode #1156
fix contrast
Removed overflow for small sizes
Collaborator

Review on #1156

Whats done

Tested on Windows using Firefox

  • App starts
    • No issues found
  • Tested translate card at different sizes, the button no longer overflows

Inspected following files

  • frontend/src/features/translator/translator.module.css
    • Indentation/code styling
      • Extra space in grid-template-columns: 1fr auto auto; This should be single space
    • CSS standard
      • min-width: 0 fixes the overflow, follows standard
    • Comments
      • Looks good
    • General code quality
      • No issues

What needs to be done

  • Remove the extra space in grid-template-columns: 1fr auto auto;

Conclusion

  • Fixes the overflow, one minor fix needed.
# Review on #1156 ## Whats done ### Tested on Windows using Firefox + App starts + No issues found + Tested translate card at different sizes, the button no longer overflows ### Inspected following files + frontend/src/features/translator/translator.module.css + Indentation/code styling + Extra space in grid-template-columns: 1fr auto auto; This should be single space + CSS standard + min-width: 0 fixes the overflow, follows standard + Comments + Looks good + General code quality + No issues ## What needs to be done + Remove the extra space in grid-template-columns: 1fr auto auto; ## Conclusion + Fixes the overflow, one minor fix needed.
space fixed
Author
Collaborator

@c24carso thanks for the review, fixed the spacing now

@c24carso thanks for the review, fixed the spacing now
c24carso approved these changes 2026-05-26 17:17:27 +00:00
a22erigr merged commit 14cc43ac94 into both_teams_week_8 2026-05-26 17:55:50 +00:00
a22erigr deleted branch 1156-button-overflow 2026-05-26 17:55:50 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!1179
No description provided.