Andras/BoundlessFlowCampus2K

Fork 0

General cleanup of several files #1180

Merged

a22erigr merged 3 commits from General-cleanup into both_teams_week_8

2026-05-27 07:57:02 +00:00

a24timsv commented

2026-05-26 12:44:23 +00:00

Collaborator

This involves:

The old monolithic compose file.
The database in the Västtrafik compose.
Modals being spelled correctly.
Some .idea files from someone using JetBrains.
Deleting unused environment variables.

This should not cause any issues as some deletes are not even code related. But a check would be nice.

Started checking whether or not some environment variables were necessary, which devolved into seeing files that shouldn't be where they are, which devolved into deleting files that shouldn't be where they are. This involves: - The old monolithic compose file. - The database in the Västtrafik compose. - Modals being spelled correctly. - Some .idea files from someone using JetBrains. - Deleting unused environment variables. This should not cause any issues as some deletes are not even code related. But a check would be nice.

a24timsv added the

cleanup

needs review

labels

2026-05-26 12:44:23 +00:00

a24timsv added 2 commits

2026-05-26 12:44:24 +00:00

Enviroment variable change in Menu (+ cleanup) 9552319adb

Removed so that MenuService doesn't use the ICS URL, as it is not a secret variable. Also saw some .idea files in layout and login service, removed and added to gitignore

Removed database in Västrafik service 1088f874a4

Removed VästrafikService's database, as it doesn't use it as far as I know.

Also removed the big compose file as it is not used anymore.

a24vinla was assigned by a24sakma

2026-05-27 07:13:10 +00:00

a24sakma removed the

needs review

label

2026-05-27 07:14:48 +00:00

a24vinla added 1 commit

2026-05-27 07:29:04 +00:00

Removed outdated comment c92337819d

a24vinla commented

2026-05-27 07:29:17 +00:00

Collaborator

Review on # not apparent

Whats done

Tested on Windows

App starts!

Inspected following files

.gitignore
- Necessary addition
DockerCompose/compose.yaml - removed
- Not in use anymore, good to remove
DockerCompose/stacks/menu/compose.yaml
- Since it is a public API there is no need to have it in .env
DockerCompose/stacks/vasttrafik/compose.yaml
- Does not use database, good to remove!
- Does not need to communicate with internal network
layoutService and loginService .idea files - removed
- 👍
service/menuService/menuService/Modals → service/menuService/menuService/Models
- 👍
service/menuService/menuService/Util/Ics/IcsFetcher.cs
- Should remove comment on how we get the URL from IConfiguration, which I did myself!

What needs to be done

Nothing

Conclusion

Good PR!

# Review on # not apparent ## Whats done ### Tested on Windows + App starts! ### Inspected following files + .gitignore + Necessary addition + DockerCompose/compose.yaml - removed + Not in use anymore, good to remove + DockerCompose/stacks/menu/compose.yaml + Since it is a public API there is no need to have it in .env + DockerCompose/stacks/vasttrafik/compose.yaml + Does not use database, good to remove! + Does not need to communicate with internal network + layoutService and loginService .idea files - removed + 👍 + service/menuService/menuService/Modals → service/menuService/menuService/Models + 👍 + service/menuService/menuService/Util/Ics/IcsFetcher.cs + Should remove comment on how we get the URL from IConfiguration, which I did myself! ## What needs to be done Nothing ## Conclusion Good PR!

a24vinla added the

reviewed

label

2026-05-27 07:29:36 +00:00

a24vinla approved these changes

2026-05-27 07:29:50 +00:00