Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

Add energy sensor selection buttons #1186

Merged
a24julot merged 8 commits from issue-1174-energy-sensor-buttons into both_teams_week_8 2026-05-28 10:44:26 +00:00
Conversation 8 Commits 8 Files changed 4 +143 -15
b25marem commented 2026-05-26 15:06:55 +00:00
Collaborator
Copy link

Frontend implementation is ready and committed.

Sensor buttons are implemented and use the existing /api/energy/sensors/ endpoint as described in the issue.

I could not fully test the API integration locally because the Docker/backend setup fails to resolve the database host (Name or service not known) in my environment, so the frontend API calls currently fail locally.

Frontend implementation is ready and committed. Sensor buttons are implemented and use the existing `/api/energy/sensors/` endpoint as described in the issue. I could not fully test the API integration locally because the Docker/backend setup fails to resolve the database host (`Name or service not known`) in my environment, so the frontend API calls currently fail locally.
c24carso commented 2026-05-27 07:38:41 +00:00
Collaborator
Copy link

Review on #1174

Whats done

Tested on Windows using Firefox

  • App starts
    • Energy view loads, sensor buttons appear
    • Switching between sensors works
    • Sensors display in reverse order (not super important)

Inspected following files

  • frontend/src/features/energy/sensor/EnergyView.js
    • Naming convention
      • Follows wiki standard
    • Comments
      • Follows wiki standard
    • General code quality
      • The sensor buttons markup is duplicated across all four return blocks. Should be extracted into a variable or component
      • The issue says to look at TemperatureView for inspiration, TemperatureView uses a dedicated hook with the shared useApi. This should do the same
      • console.error left in the catch block
      • Hardcoded fallback sensors in the catch block, would display wrong data instead of an error
  • frontend/src/features/energy/sensor/EnergyView.module.css
    • CSS standard
      • Follows wiki standard
    • Comments
      • Missing comments above rule sets

What needs to be done

  • Extract sensor buttons to avoid duplicating
  • Create a hook using useApi for fetching sensors
  • Remove console.error
  • Remove hardcoded fallback sensors
  • Add comments to CSS rule sets
  • Fix sensor order

Conclusion

  • It works but needs cleanup and changes before merge.
# Review on #1174 ## Whats done ### Tested on Windows using Firefox + App starts + Energy view loads, sensor buttons appear + Switching between sensors works + Sensors display in reverse order (not super important) ### Inspected following files + frontend/src/features/energy/sensor/EnergyView.js + Naming convention + Follows wiki standard + Comments + Follows wiki standard + General code quality + The sensor buttons markup is duplicated across all four return blocks. Should be extracted into a variable or component + The issue says to look at TemperatureView for inspiration, TemperatureView uses a dedicated hook with the shared useApi. This should do the same + console.error left in the catch block + Hardcoded fallback sensors in the catch block, would display wrong data instead of an error + frontend/src/features/energy/sensor/EnergyView.module.css + CSS standard + Follows wiki standard + Comments + Missing comments above rule sets ## What needs to be done + Extract sensor buttons to avoid duplicating + Create a hook using useApi for fetching sensors + Remove console.error + Remove hardcoded fallback sensors + Add comments to CSS rule sets + Fix sensor order ## Conclusion + It works but needs cleanup and changes before merge.
👍 1
b25marem commented 2026-05-27 07:41:33 +00:00
Author
Collaborator
Copy link

Thank you for the review. I will fix it once I finish the issue I’m currently working on.

Thank you for the review. I will fix it once I finish the issue I’m currently working on.
a24nedka commented 2026-05-27 14:38:39 +00:00
Collaborator
Copy link

I'm getting build errors , something wrong with frontend. Can't do re- review on this PR right now.

I'm getting build errors , something wrong with frontend. Can't do re- review on this PR right now.
👍 1
a24julot commented 2026-05-28 08:58:07 +00:00
Collaborator
Copy link

image

![image](/attachments/50091731-08ad-45d9-9414-f7914bdfbc93)
image.png
14 KiB
a24julot commented 2026-05-28 09:07:24 +00:00
Collaborator
Copy link

After fixing the error I could see the buttons, the buttons we had in mind were the same buttons that are implemented on TemperatureMonthView for example as mentioned in the issue #1174 !

After fixing the error I could see the buttons, the buttons we had in mind were the same buttons that are implemented on TemperatureMonthView for example as mentioned in the issue https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/1174 !
b25marem commented 2026-05-28 09:28:45 +00:00
Author
Collaborator
Copy link

fixed

fixed
b25marem commented 2026-05-28 09:33:43 +00:00
Author
Collaborator
Copy link

jag ska fixa konflikten bara

jag ska fixa konflikten bara
image.png
123 KiB
image.png
c24danli commented 2026-05-28 09:47:35 +00:00
Collaborator
Copy link

Looks good now, the mentioned issues are fixed.
Package-lock.json seems to have accidentally been included in the PR causing a conflict
EDIT: ok i see you have fixed it

Looks good now, the mentioned issues are fixed. Package-lock.json seems to have accidentally been included in the PR causing a conflict EDIT: ok i see you have fixed it
a24julot merged commit 777c4f76c6 into both_teams_week_8 2026-05-28 10:44:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
c24carso
a24nedka
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!1186
No description provided.