Andras/BoundlessFlowCampus2K

Fork 0

1161-localization-smhi-forecast #1191

Merged

a22erigr merged 1 commit from 1161-localization-smhi-forecast into both_teams_week_8

2026-05-27 11:39:12 +00:00

b24erika commented

2026-05-27 08:59:14 +00:00

Collaborator

What has changed

Adde localization for forecast view.
Added "toLowerCase" because "en-US" days start with a capital letter, which "sv-SE" does not.

## What has changed Adde localization for forecast view. Added "toLowerCase" because "en-US" days start with a capital letter, which "sv-SE" does not.

b24erika added the

frontEnd

needs review

labels

2026-05-27 08:59:14 +00:00

b24erika self-assigned this

2026-05-27 08:59:14 +00:00

b24erika added 1 commit

2026-05-27 08:59:14 +00:00

added localization and lowercase 811cf6682e

English days start with a capital letter which do not sv-SE

b24erika referenced this pull request

2026-05-27 09:00:09 +00:00

SMHI forecast localization bug #1161

a24julot

2026-05-27 10:18:34 +00:00

removed the
needs review
label
requested review from b24krila

b24krila commented

2026-05-27 10:48:40 +00:00

Collaborator

Review on #1191

Tested on Windows using Microsoft Edge and Google Chrome
App starts
The localization works

Inspected following files:
frontend/src/features/smhi/SMHIForecastView.js
frontend/src/locales/en.json
frontend/src/locales/sv.json

The code looks good and follows prettier.

What needs to be done

Nothing

Conclusion

The issue seems to have been fixed and can be merged without any issues.

Review on #1191 Tested on Windows using Microsoft Edge and Google Chrome App starts The localization works Inspected following files: frontend/src/features/smhi/SMHIForecastView.js frontend/src/locales/en.json frontend/src/locales/sv.json The code looks good and follows prettier. ### What needs to be done Nothing ### Conclusion The issue seems to have been fixed and can be merged without any issues.

b24erika commented

2026-05-27 10:55:46 +00:00

Author

Collaborator

@b24krila wrote in #1191 (comment):

Review on #1191

Tested on Windows using Microsoft Edge and Google Chrome App starts The localization works

Inspected following files: frontend/src/features/smhi/SMHIForecastView.js frontend/src/locales/en.json frontend/src/locales/sv.json

The code looks good and follows prettier.

What needs to be done

Nothing

Conclusion

The issue seems to have been fixed and can be merged without any issues.

Thanks for the review! If you consider that the solution is sufficient and your review is done, please mark it as "reviewed", thanks!

@b24krila wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/1191#issuecomment-14613: > Review on #1191 > > Tested on Windows using Microsoft Edge and Google Chrome App starts The localization works > > Inspected following files: frontend/src/features/smhi/SMHIForecastView.js frontend/src/locales/en.json frontend/src/locales/sv.json > > The code looks good and follows prettier. > ### [](#what-needs-to-be-done)What needs to be done > > Nothing > ### [](#conclusion)Conclusion > > The issue seems to have been fixed and can be merged without any issues. Thanks for the review! If you consider that the solution is sufficient and your review is done, please mark it as "reviewed", thanks!

b24krila added the

reviewed

label

2026-05-27 10:57:11 +00:00

b24krila commented

2026-05-27 10:57:25 +00:00

Collaborator

@b24erika wrote in #1191 (comment):

@b24krila wrote in #1191 (comment):

Review on #1191
Tested on Windows using Microsoft Edge and Google Chrome App starts The localization works
Inspected following files: frontend/src/features/smhi/SMHIForecastView.js frontend/src/locales/en.json frontend/src/locales/sv.json
The code looks good and follows prettier.

What needs to be done

Nothing

Conclusion

The issue seems to have been fixed and can be merged without any issues.

Thanks for the review! If you consider that the solution is sufficient and your review is done, please mark it as "reviewed", thanks!

Done, Forgot to do it.

@b24erika wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/1191#issuecomment-14624: > @b24krila wrote in #1191 (comment): > > > Review on #1191 > > Tested on Windows using Microsoft Edge and Google Chrome App starts The localization works > > Inspected following files: frontend/src/features/smhi/SMHIForecastView.js frontend/src/locales/en.json frontend/src/locales/sv.json > > The code looks good and follows prettier. > > ### [](#what-needs-to-be-done-what-needs-to-be-done)What needs to be done > > Nothing > > ### [](#conclusion-conclusion)Conclusion > > The issue seems to have been fixed and can be merged without any issues. > > Thanks for the review! If you consider that the solution is sufficient and your review is done, please mark it as "reviewed", thanks! Done, Forgot to do it.

👍 1