Andras/BoundlessFlowCampus2K

Fork 0

1192-darker-bg-dark-mode #1194

Merged

a24julot merged 1 commit from 1192-darker-bg-dark-mode into both_teams_week_8

2026-05-27 11:11:23 +00:00

b24erika commented

2026-05-27 09:52:38 +00:00

Collaborator

What has changed

Due to regular color-themes do not set their own bg-color and uses root, the change of bg color is root to make it darker.

## What has changed Due to regular color-themes do not set their own bg-color and uses root, the change of bg color is root to make it darker.

b24erika added the

frontEnd

needs review

labels

2026-05-27 09:52:38 +00:00

b24erika self-assigned this

2026-05-27 09:52:38 +00:00

b24erika added 1 commit

2026-05-27 09:52:38 +00:00

change bg color to darker in darkmode 8a1ac52950

b24erika referenced this pull request

2026-05-27 09:53:31 +00:00

Change color of toolbar #1192

a24julot

2026-05-27 10:37:45 +00:00

removed the
needs review
label
requested review from e24aleli

e24aleli commented

2026-05-27 10:53:23 +00:00

Collaborator

Review on #1194

Whats done

Looked over the changes in code (only colors was replaced so not that much)

Tested on MacOS using Helium

The issue is fulfilled dark mode is darker.
Coding principles and indentation is still intact.

What needs to be done

Shouldn't the header also have the same color or a color that compliments the dark body more?

Conclusion

The issue is fulfilled darkmode is in fact darker!
But the header now looks little out of place (colorwise). Might just be a "smaksak" in this case can be dismissed.

# Review on #1194 ## Whats done Looked over the changes in code (only colors was replaced so not that much) ### Tested on MacOS using Helium The issue is fulfilled dark mode is darker. Coding principles and indentation is still intact. ## What needs to be done Shouldn't the header also have the same color or a color that compliments the dark body more? ## Conclusion The issue is fulfilled darkmode is in fact darker! But the header now looks little out of place (colorwise). Might just be a "smaksak" in this case can be dismissed. ![image](/attachments/fc6ceb0d-e201-4646-b8be-35c9e4af63f9)

image.png

193 KiB

e24aleli added the

reviewed

label

2026-05-27 11:00:18 +00:00

b24erika commented

2026-05-27 11:03:22 +00:00

Author

Collaborator

@e24aleli wrote in #1194 (comment):

Review on #1194

Whats done

Looked over the changes in code (only colors was replaced so not that much)

Tested on MacOS using Helium

The issue is fulfilled dark mode is darker. Coding principles and indentation is still intact.

What needs to be done

Shouldn't the header also have the same color or a color that compliments the dark body more?

Conclusion

The issue is fulfilled darkmode is in fact darker! But the header now looks little out of place (colorwise).

This is a problem when selecting base, there is no "base theme" and the styling is root, to solve this root should perhaps be re-worked or add the "root-theme". This should be another issue since this pull-request was mainly for setting a darker toolbar.

@e24aleli wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/1194#issuecomment-14622: > # [](#review-on-1194)Review on #1194 > ## [](#whats-done)Whats done > > Looked over the changes in code (only colors was replaced so not that much) > ### [](#tested-on-macos-using-helium)Tested on MacOS using Helium > > The issue is fulfilled dark mode is darker. Coding principles and indentation is still intact. > ## [](#what-needs-to-be-done)What needs to be done > > Shouldn't the header also have the same color or a color that compliments the dark body more? > ## [](#conclusion)Conclusion > > The issue is fulfilled darkmode is in fact darker! But the header now looks little out of place (colorwise). > > [![image](/attachments/fc6ceb0d-e201-4646-b8be-35c9e4af63f9)](/Andras/BoundlessFlowCampus2K/attachments/fc6ceb0d-e201-4646-b8be-35c9e4af63f9) This is a problem when selecting base, there is no "base theme" and the styling is root, to solve this root should perhaps be re-worked or add the "root-theme". This should be another issue since this pull-request was mainly for setting a darker toolbar.

a24julot merged commit 69a22a8333 into both_teams_week_8

2026-05-27 11:11:23 +00:00

a24julot referenced this pull request from a commit

2026-05-27 11:11:23 +00:00

Merge pull request '1192-darker-bg-dark-mode' (#1194) from 1192-darker-bg-dark-mode into both_teams_week_8