Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

Made a more user friendly message when no image is selected #1249

Open
a24hamrh wants to merge 2 commits from Image-view-error-1230 into both_teams_week_8
pull from: Image-view-error-1230
merge into: Andras:both_teams_week_8
Conversation 1 Commits 2 Files changed 2 +3 -3
a24hamrh commented 2026-06-11 19:34:41 +00:00
Collaborator
Copy link

When no image is selected there is a message "no image selected" instead of a HTTP error message

When no image is selected there is a message "no image selected" instead of a HTTP error message
When no image is selected there is a message "no image selected" instead of a HTTP error message
a24hamrh commented 2026-06-11 19:46:38 +00:00
Author
Collaborator
Copy link

Review on #1249

Whats done

Tested on Windows using Firefox

  • App starts
    • Added image card and new message appear when no image is selected

Inspected following files: ImageView.js and useImage.js

  • Both
    • Indentation/code styling
      • Indentation is ok
    • Naming convention
      • Naming convention is followed
    • Printed text uses and follows localization standards
      • Localization convention is followed
    • Comments
      • Good amounts of comments
    • General code quality
      • General code quality is good

Conclusion

  • The code looks good and a more user friendly text is displayed when no image is selected
# Review on #1249 ## Whats done ### Tested on Windows using Firefox + App starts + Added image card and new message appear when no image is selected ### Inspected following files: ImageView.js and useImage.js + Both + Indentation/code styling + Indentation is ok + Naming convention + Naming convention is followed + Printed text uses and follows localization standards + Localization convention is followed + Comments + Good amounts of comments + General code quality + General code quality is good ## Conclusion + The code looks good and a more user friendly text is displayed when no image is selected
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin Image-view-error-1230:Image-view-error-1230
git switch Image-view-error-1230

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch both_teams_week_8
git merge --no-ff Image-view-error-1230
git switch Image-view-error-1230
git rebase both_teams_week_8
git switch both_teams_week_8
git merge --ff-only Image-view-error-1230
git switch Image-view-error-1230
git rebase both_teams_week_8
git switch both_teams_week_8
git merge --no-ff Image-view-error-1230
git switch both_teams_week_8
git merge --squash Image-view-error-1230
git switch both_teams_week_8
git merge --ff-only Image-view-error-1230
git switch both_teams_week_8
git merge Image-view-error-1230
git push origin both_teams_week_8
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!1249
No description provided.