removed vertical scrollbar and styled horizontal #1250

Open
e24aleli wants to merge 1 commit from #1239-Remove-Vertical-Scroll into both_teams_week_8
Collaborator

Removed vertical scroll and took the time to "style" the horizontal scrollbar since it was so thick.

Made it thinner and autohides.

I believe the horizontal scrollbar serves a function to let the user know there is more categories to scroll through

Removed vertical scroll and took the time to "style" the horizontal scrollbar since it was so thick. Made it thinner and autohides. I believe the horizontal scrollbar serves a function to let the user know there is more categories to scroll through
Author
Collaborator

Review on #1250

Whats done

Tested on MacOS using Helium

  • App starts
    • Tested by going to the add view modal and dragged the categories in mobile view.

Inspected following files

  • AddCardModel.module.css
    • Indentation/code styling
      • Indentation OK
    • CSS standard
      • Changes follows the standards and did not need improvements.
    • Naming convention
      • Naming Convention OK
    • Printed text uses and follows localization standards
      • Localization Standards OK
    • Comments
      • Mostly self-explanatory changes and the one comment is OK
    • General code quality
      • General Code Quality GOOD

Conclusion

  • Code looks good and does what it is supposed to in order to fulfill the regarding issue.
# Review on #1250 ## Whats done ### Tested on MacOS using Helium + App starts + Tested by going to the add view modal and dragged the categories in mobile view. ### Inspected following files + AddCardModel.module.css + Indentation/code styling + Indentation OK + CSS standard + Changes follows the standards and did not need improvements. + Naming convention + Naming Convention OK + Printed text uses and follows localization standards + Localization Standards OK + Comments + Mostly self-explanatory changes and the one comment is OK + General code quality + General Code Quality GOOD ## Conclusion + Code looks good and does what it is supposed to in order to fulfill the regarding issue.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin #1239-Remove-Vertical-Scroll:#1239-Remove-Vertical-Scroll
git switch #1239-Remove-Vertical-Scroll

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch both_teams_week_8
git merge --no-ff #1239-Remove-Vertical-Scroll
git switch #1239-Remove-Vertical-Scroll
git rebase both_teams_week_8
git switch both_teams_week_8
git merge --ff-only #1239-Remove-Vertical-Scroll
git switch #1239-Remove-Vertical-Scroll
git rebase both_teams_week_8
git switch both_teams_week_8
git merge --no-ff #1239-Remove-Vertical-Scroll
git switch both_teams_week_8
git merge --squash #1239-Remove-Vertical-Scroll
git switch both_teams_week_8
git merge --ff-only #1239-Remove-Vertical-Scroll
git switch both_teams_week_8
git merge #1239-Remove-Vertical-Scroll
git push origin both_teams_week_8
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!1250
No description provided.