Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

added a new variable for the progress bar #1251

Open
e24aleli wants to merge 1 commit from #1242-prog-bar-colors-fix into both_teams_week_8
pull from: #1242-prog-bar-colors-fix
merge into: Andras:both_teams_week_8
Conversation 1 Commits 1 Files changed 2 +20 -2
e24aleli commented 2026-06-25 17:36:19 +00:00
Collaborator
Copy link

Added a variable for the progress bar fill and background because the colors used before clashed when using with the progressbar. To help with weird contrast i inverted the colors for dark mode so that the background is dark and fill is light instead, this imo makes it more visually appealing.

image
image

Added a variable for the progress bar fill and background because the colors used before clashed when using with the progressbar. To help with weird contrast i inverted the colors for dark mode so that the background is dark and fill is light instead, this imo makes it more visually appealing. ![image](/attachments/ad3e6ca1-fa36-4a64-b920-aa847a9b2228) ![image](/attachments/53921444-103a-4986-b022-a5a0b796594c)
image.png
259 KiB
image.png
264 KiB
e24aleli commented 2026-06-28 23:27:08 +00:00
Author
Collaborator
Copy link

Review on #1251

Whats done

Tested on MacOS using Helium

  • App starts
    • Tested by trying out all variations for dark/lightmode + themes.

Inspected following files

  • frontend/src/features/text/ToDoView.module.css
    • [Check following things]
    • Indentation/code styling OK
    • CSS standard OK
    • Naming convention OK
    • Printed text uses and follows localization standards OK
    • Comments, not needed for the CSS changes it is just color changes.
    • General code quality OK

Conclusion

The provided PR solves the issue of the progress bar not showing with some themes. Contrast has been improved for both dark and light mode and every variation is visible now.

# Review on #1251 ## Whats done ### Tested on MacOS using Helium + App starts + Tested by trying out all variations for dark/lightmode + themes. ### Inspected following files + frontend/src/features/text/ToDoView.module.css + [Check following things] + Indentation/code styling OK + CSS standard OK + Naming convention OK + Printed text uses and follows localization standards OK + Comments, not needed for the CSS changes it is just color changes. + General code quality OK ## Conclusion The provided PR solves the issue of the progress bar not showing with some themes. Contrast has been improved for both dark and light mode and every variation is visible now.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin #1242-prog-bar-colors-fix:#1242-prog-bar-colors-fix
git switch #1242-prog-bar-colors-fix

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch both_teams_week_8
git merge --no-ff #1242-prog-bar-colors-fix
git switch #1242-prog-bar-colors-fix
git rebase both_teams_week_8
git switch both_teams_week_8
git merge --ff-only #1242-prog-bar-colors-fix
git switch #1242-prog-bar-colors-fix
git rebase both_teams_week_8
git switch both_teams_week_8
git merge --no-ff #1242-prog-bar-colors-fix
git switch both_teams_week_8
git merge --squash #1242-prog-bar-colors-fix
git switch both_teams_week_8
git merge --ff-only #1242-prog-bar-colors-fix
git switch both_teams_week_8
git merge #1242-prog-bar-colors-fix
git push origin both_teams_week_8
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
e24aleli
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!1251
No description provided.