Andras/BoundlessFlowCampus2K
3
6
Fork 0
Code Issues 143 Pull requests 14 Projects Releases Packages Wiki Activity Actions 2

#164-165-mqtt-auth #216

Merged
c24elipe merged 3 commits from #164-165-mqtt-auth into team_2_week_1 2026-04-10 13:54:35 +00:00
Conversation 2 Commits 3 Files changed 5 +77 -18
b25marem commented 2026-04-10 07:00:32 +00:00
Collaborator
Copy link

This branch builds on the existing MQTT authentication implementation from #10-mqtt-login.

In this work, authentication has been integrated into both services:
middleware & readTempSensorMockup

Both services now connect to the MQTT broker using credentials, and the full data flow has been verified.

This branch builds on the existing MQTT authentication implementation from #10-mqtt-login. In this work, authentication has been integrated into both services: middleware & readTempSensorMockup Both services now connect to the MQTT broker using credentials, and the full data flow has been verified.
c24elipe removed their assignment 2026-04-10 10:46:15 +00:00
c24elipe removed their assignment 2026-04-10 10:46:31 +00:00
b23albst commented 2026-04-10 13:27:08 +00:00
Collaborator
Copy link

I reviewed the code in the change files to make sure that the changes seemed reasonable and follows the coding standards, which it did.
I ran the program and checked the console prints too see if there were any errors. There were not. I also tested running the application to see if there were any errors and to see that the temperature data was till correctly displayed. There were no errors.
Furthermore I tried removing the authentication to make sure that you would not be able to connect to the broker without proper authentication. In this case, it was unable to connect, verified both through console print outs and no data being able to be displayed on the application.

This looks ok to me. No one will be able to connect to the mqqt broker without authentication.

I reviewed the code in the change files to make sure that the changes seemed reasonable and follows the coding standards, which it did. I ran the program and checked the console prints too see if there were any errors. There were not. I also tested running the application to see if there were any errors and to see that the temperature data was till correctly displayed. There were no errors. Furthermore I tried removing the authentication to make sure that you would not be able to connect to the broker without proper authentication. In this case, it was unable to connect, verified both through console print outs and no data being able to be displayed on the application. This looks ok to me. No one will be able to connect to the mqqt broker without authentication.
c24elipe commented 2026-04-10 13:54:26 +00:00
Collaborator
Copy link

Looked through the files, and the syntax looks alright.
I have to trust 100% @b23albst that it runs correctly due to Docker build problems on my end.

Condition, merging

Looked through the files, and the syntax looks alright. I have to trust 100% @b23albst that it runs correctly due to Docker build problems on my end. Condition, merging
c24elipe merged commit cbdf20e0ab into team_2_week_1 2026-04-10 13:54:35 +00:00
c24elipe deleted branch #164-165-mqtt-auth 2026-04-10 13:54:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
b23albst
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked-waiting-for-further-changes

   
bug

Something is not working

  
bug-only-on-server-for-mobile-not-webpage

   
Bug-Report-After-Merge

   
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
further-changes-needed

   
future-problem-not-fixint-this-period

   
help wanted

Need some help

  
invalid

Something is wrong

  
last-week-issue-to-fix

   
library

   
low-priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
not-implemented.

   
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
Script

   
security

use this for security-related issues

  
SQL

  
style

   
Team 1

Team 1 is responsible for this issue

  
Team 2

Team 2 is responsible for this issue

  
team leaders

   
test-creation

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
unassigned

   
Under-review

   
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
b25marem
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!216
No description provided.