Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

#20 Average temperature for year, and a cache #227

Closed
b24hugst wants to merge 14 commits from #20-aggregated-data-for-tempservice into team_1_week_1
pull from: #20-aggregated-data-for-tempservice
merge into: Andras:team_1_week_1
Conversation 5 Commits 14 Files changed 4 +100 -5
b24hugst commented 2026-04-10 10:22:00 +00:00
Collaborator
Copy link

A new card showing the average temperature from that specific year.

Works together with a cache that updates every 10 minutes to increase performance.

Cache seems to work as I checked the logs during execution and it first prints that it looks for database
, and then on the second request, it prints that it requested from cache instead.

This was a part of the #20 issue.

New sub-issues for adding /year/month and /year/week are needed.

Maybe also an issue for fixing the frontend output, because right now I have just statically set it to always show 2026, and it also shows on any URL and not only on /temperature/2026

A new card showing the average temperature from that specific year. Works together with a cache that updates every 10 minutes to increase performance. Cache seems to work as I checked the logs during execution and it first prints that it looks for database , and then on the second request, it prints that it requested from cache instead. ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- This was a part of the #20 issue. New sub-issues for adding **/year/month** and **/year/week** are needed. Maybe also an issue for fixing the frontend output, because right now I have just statically set it to always show 2026, and it also shows on any URL and not only on **/temperature/2026**
Screenshot 2026-04-10 122109.png
2.5 KiB
Screenshot 2026-04-10 122109.png 
returns average temperature for the written year
Shows 2026 average temperature currently
Showcases average temperature from that month
Outputs average temperature for written month
months addressed with ints instead of strings and also datatype int added in parameter
Decided it's better to save this for another issue
Noticed I missed this
needed to save database results into cache
Cache will now get checked before database, and updated every 10 minutes
a24hirsa commented 2026-04-10 13:29:25 +00:00
Collaborator
Copy link

Code looks good and is well commented and structure. There is a minor merge conflict with the App.js mostly due to it being used to test displaying information meaning it no longer matches the changes currently made in the group branch.

You can fix this merge conflict by merging the group branch into your working branch then selecting to use the group branches version of the app.js file when fixing conflicts. If your unsure about or nervous about this process tell me and i can fix it tomorrow. When this is fixed its ready to be merged into the group branch

Code looks good and is well commented and structure. There is a minor merge conflict with the App.js mostly due to it being used to test displaying information meaning it no longer matches the changes currently made in the group branch. You can fix this merge conflict by merging the group branch into your working branch then selecting to use the group branches version of the app.js file when fixing conflicts. If your unsure about or nervous about this process tell me and i can fix it tomorrow. When this is fixed its ready to be merged into the group branch
a24hirsa removed their assignment 2026-04-10 13:32:47 +00:00
a24hirsa 2026-04-10 13:32:59 +00:00
b24hugst commented 2026-04-10 13:59:07 +00:00
Author
Collaborator
Copy link

@a24hirsa Ah ok yeah I'll do that. Thanks for the guide.

@a24hirsa Ah ok yeah I'll do that. Thanks for the guide.
b24johka commented 2026-04-13 10:01:10 +00:00
Collaborator
Copy link

Is this derived from an issue? we're a little confused where this came from. Usually the issue number is added to the title of the branch.

Is this derived from an issue? we're a little confused where this came from. Usually the issue number is added to the title of the branch.
b24hugst changed title from Average temperature for year, and a cache to #20 Average temperature for year, and a cache 2026-04-13 11:43:54 +00:00
b24hugst commented 2026-04-13 11:46:21 +00:00
Author
Collaborator
Copy link

@b24johka wrote in #227 (comment):

Is this derived from an issue? we're a little confused where this came from. Usually the issue number is added to the title of the branch.

I updated the title now. I did however write that it's from the #20 issue but it was a little hidden.

This was only a sub-part of the #20 issue, I'm working on the rest of it right now but thought this could get pulled in the meantime. Although I'll update this as well to meet the new home.js requirements.

@b24johka wrote in https://git.webug.se/Andras/BoundlessFlowCampus2K/pulls/227#issuecomment-2261: > Is this derived from an issue? we're a little confused where this came from. Usually the issue number is added to the title of the branch. I updated the title now. I did however write that it's from the #20 issue but it was a little hidden. This was only a sub-part of the #20 issue, I'm working on the rest of it right now but thought this could get pulled in the meantime. Although I'll update this as well to meet the new home.js requirements.
b24hugst commented 2026-04-13 12:46:31 +00:00
Author
Collaborator
Copy link

Actually. Could you close this pull request all together so I can create a new one? Because I have a new branch with the new structure of home.js and that, which I don't want to have to change again on this branch. And I also have implemented so /year/month works as well.

Actually. Could you close this pull request all together so I can create a new one? Because I have a new branch with the new structure of home.js and that, which I don't want to have to change again on this branch. And I also have implemented so /year/month works as well.
b24hugst 2026-04-13 12:50:07 +00:00
  • closed this pull request
  • added the
    wontfix
         label

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
a24hirsa
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!227
No description provided.