#234-Extend-the-test-scope-for-tempSensorMockup #255

Closed

f21marfo wants to merge 0 commits from #234-Extend-the-test-scope-for-tempSensorMockup into temp-week-2-merge-branch

f21marfo commented

2026-04-13 09:52:42 +00:00

Collaborator

Completed unit test suite for tempSensorMockup

Validates the data-structure returned by the endpoint.
Individually validates the validity of the data for each returned datatype, sensorId, timestamp, temperature.

Completed unit test suite for tempSensorMockup - Validates the data-structure returned by the endpoint. - Individually validates the validity of the data for each returned datatype, sensorId, timestamp, temperature.

f21marfo added the

testing

needs review

labels

2026-04-13 09:52:42 +00:00

f21marfo added 4 commits

2026-04-13 09:52:43 +00:00

Fixed the existing test for tempSensorMockup cb6bc60195

The existing test for tempSensorMockup was not a true unit test, and had issues connecting to to the running api in the docker container.

Imported package Microsoft.AspNetCore.Mvc.Testing in order to use the WebApplicationFactory() to create an in-memory copy of the tempSensorMockup so that it can be correctly tested.

Completed JsonData_TagsCorrect_ReturnTrue() test d973d97857

JsonData_TagsCorrect_ReturnTrue() will now accurately validate the data structure of tempSensorMockup.

It will fail for the following:
- If the parsed JSON contains ANY unexpected property names.
- If the parsed JSON has to few or too many properties.

Todo: Data validation

Enhanced robustness of the tempSensorMockup datastructure test. 7140ecb128

Enhanced the test to establish the uniqueness of the returned JSON properties. Example: A faulty JSON that has the property Data occurring twice, will fail the test, rather than being waved through.

Completed Creation of tests acf757b1f0

- Extended unit tests to validate each of the expected three values.
- Refactored all tests to try and conform with unit test guidelines, as best as possible by subdividing the data validation tests and structuring them in accordance with the three "A's", where possible.

c24elipe requested review from b25marem

2026-04-13 11:08:06 +00:00

f21marfo was assigned by c24elipe

2026-04-13 11:08:17 +00:00

b25marem commented

2026-04-13 12:50:45 +00:00

Collaborator

read through the test code and related PR description
checked that the validated JSON fields are descriptive and follow camelCase (sensorId, timestamp, temperature)
resolved the merge conflicts locally by keeping the test files from this PR
ran the test suite with dotnet test the resykt: the project built successfully
all 4 tests passed. The JSON validation in the test suite appears to work as expected with the local conflict resolution

read through the test code and related PR description checked that the validated JSON fields are descriptive and follow camelCase (sensorId, timestamp, temperature) resolved the merge conflicts locally by keeping the test files from this PR ran the test suite with dotnet test the resykt: the project built successfully all 4 tests passed. The JSON validation in the test suite appears to work as expected with the local conflict resolution