Andras/BoundlessFlowCampus2K

Fork 0

#262 Created the buttons Primary, Secondary and Danger #268

Merged

b24johka merged 4 commits from #262-Create-Standard-CSS-For-Buttons into team_1_week_1

2026-04-14 10:57:09 +00:00

b24johka commented

2026-04-13 16:18:57 +00:00

Collaborator

Sizing, colors, borders. and border radius has been centralized.
We have chosen the primary button color based on the university colors.
Same goes for the Secondary button.
Cancel buttons have the "Danger button"class, which is a bright red color.
Not that it doesnt have a transition like the others because of the risk when having a danger button.

Sizing, colors, borders. and border radius has been centralized. We have chosen the primary button color based on the university colors. Same goes for the Secondary button. Cancel buttons have the "Danger button"class, which is a bright red color. Not that it doesnt have a transition like the others because of the risk when having a danger button.

Screencast from 2026-04-13 17-19-38.webm

442 KiB

b24johka added 1 commit

2026-04-13 16:18:58 +00:00

Created the buttons Primary, Secondary and Danger 77f3029a35

b24johka commented

2026-04-13 16:20:21 +00:00

Author

Collaborator

No description provided.

Screenshot from 2026-04-13 18-19-38.png

6.7 KiB

b24johka added 1 commit

2026-04-14 08:59:21 +00:00

Merge branch 'team_1_week_1' into #262-Create-Standard-CSS-For-Buttons 56b2639154

b24johka added 1 commit

2026-04-14 09:38:29 +00:00

Further changes to match university settings 9e1aa5a5ec

b24johka commented

2026-04-14 09:39:41 +00:00

Author

Collaborator

Further changes video

Screencast from 2026-04-14 10-56-51.mp4

48 KiB

b24johka

2026-04-14 09:45:52 +00:00

added the
frontEnd
label
requested review from f21marfo

b24johka changed title from ~~Created the buttons Primary, Secondary and Danger~~ to #262 Created the buttons Primary, Secondary and Danger

2026-04-14 09:49:28 +00:00

f21marfo commented

2026-04-14 10:38:56 +00:00

Collaborator

Reviewed:

CSS Style sheet seems to follow established criteria.
Identation - Check
Naming convections - Check
Hex for colors - Check
Comments - check
Spaces after “ : “ - Check
Spaces before " { " - Mostly, .btn-primary:focus{ and .btn-secondary:focus{ are missing.

Reviewed: CSS Style sheet seems to follow established criteria. Identation - Check Naming convections - Check Hex for colors - Check Comments - check Spaces after “ : “ - Check Spaces before " { " - Mostly, .btn-primary:focus{ and .btn-secondary:focus{ are missing.

b24johka added 1 commit

2026-04-14 10:56:12 +00:00

Fixed reviewer comments 0441466ba5

b24johka commented

2026-04-14 10:57:04 +00:00

Author

Collaborator

Great catch! the reviewer has done a good job at reviewing so i will commit it into the team branch.

b24johka merged commit ecd55f555d into team_1_week_1

2026-04-14 10:57:09 +00:00

b24johka referenced this pull request from a commit

2026-04-14 10:57:10 +00:00