#275 Created new scripts and updated compose #280

Merged
c24elipe merged 3 commits from #275-Create-multiple-Init-SQL-scripts into team_2_week_1 2026-04-14 09:24:11 +00:00
Collaborator

Created new script structure for SQL init. It now allows for multiple scripts.

All changes made are located within the DockerCompose folder.
Made 1 change to the compose file (postgress section), and added all content in the 'DockerCompose/init_sql" folder.

Created new script structure for SQL init. It now allows for multiple scripts. All changes made are located within the DockerCompose folder. Made 1 change to the compose file (postgress section), and added all content in the 'DockerCompose/init_sql" folder.
Collaborator

Review on #275

Whats done

  • Run the code on Fedora 43
    • Works without problem.
  • Inspected files
    • Dockercompose
    • Init_sql/
      • 00_general
      • 01_sensor
      • 02_general

What needs to be improved

  • Do not follow SQL comment standard in files
    • 01_sensor
    • 02_general
  • Uses three --- instead of the standard two --.
  • Does not follow the standard for multiple lines comments.

Conclusion

  • +Overall solid structure.
  • +Clear and necessary comments.
  • -Uses three --- instead for standard two --
  • -Does not use /**/ for multiple line comments.
# Review on #275 ## Whats done + Run the code on Fedora 43 + Works without problem. + Inspected files + Dockercompose + Init_sql/ + 00_general + 01_sensor + 02_general ## What needs to be improved + Do not follow SQL comment standard in files + 01_sensor + 02_general + Uses three --- instead of the standard two --. + Does not follow the standard for multiple lines comments. ## Conclusion + +Overall solid structure. + +Clear and necessary comments. + -Uses three --- instead for standard two -- + -Does not use /**/ for multiple line comments.
Collaborator

Review on #275 2

whats done

  • Looked at the changed made to the comments.

Conclusion

  • The comments now follows our SQL standard.
  • The code is ready to be pulled
# Review on #275 2 ## whats done + Looked at the changed made to the comments. ## Conclusion + The comments now follows our SQL standard. + The code is ready to be pulled
Author
Collaborator

The review looks good to me. And it works locally for me.

The review looks good to me. And it works locally for me.
c24elipe merged commit bb30af5f40 into team_2_week_1 2026-04-14 09:24:11 +00:00
c24elipe deleted branch #275-Create-multiple-Init-SQL-scripts 2026-04-14 09:24:12 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!280
No description provided.