Andras/BoundlessFlowCampus2K

Fork 0

#266 A Footer for the webpage #291

Closed

b24jonel wants to merge 0 commits from #266-make-a-footer into temp-week-2-merge-branch

b24jonel commented

2026-04-14 12:13:19 +00:00

Collaborator

A footer has now been made which scales with the size of the main content and is always at the bottom of the page.

Skärmbild 2026-04-14 141100.png

48 KiB

b24jonel added 3 commits

2026-04-14 12:13:19 +00:00

#266 Footer e122e37541

Started making the Footer.js and Footer.module.css

The Footer is done d1de4b0e1f

The footer is done, now all that needs to be done is making mockup links and headers to what the footer could link to later

Footer placeholders f624b1af9a

Place holders are now in place

b24jonel added the

needs review

label

2026-04-14 12:20:11 +00:00

b24krila was assigned by b24johka

2026-04-14 12:42:59 +00:00

b24johka requested review from b24krila

2026-04-14 12:49:13 +00:00

b24krila was unassigned by b24johka

2026-04-14 12:49:35 +00:00

a24vinla requested review from a24nedka

2026-04-14 13:19:25 +00:00

b24krila commented

2026-04-14 13:53:00 +00:00

Collaborator

I have reviewed the footer implementation on the current branch.

The footer renders correctly and is visible and no errors were observed as the application builds and runs successfully.

Code review findings:

The footer component follows the react structure and is properly separated into its own module.
CSS module usage is correctly applied and layout is visually consistent on a standard desktop resolution
The application currently runs as expected

Improvements:

Responsive layout issue when reducing the browsers width the footer grid layout does not properly adapt in its current state but should be adjusted in the future. In my test 2 of the place holders were no longer visible on the smaller screen.

Issues:

Comments have mixed language both Swedish and English.
There are some slight convention problem with spaces and missing semicolons (e.g missing semicolon on import { BrowserRouter .... } ) .

Conclusion:
the implementation technically works correctly and meets the requirements so there are no blocking issues found but it requires fixing to be regarded complete.

I have reviewed the footer implementation on the current branch. The footer renders correctly and is visible and no errors were observed as the application builds and runs successfully. Code review findings: - The footer component follows the react structure and is properly separated into its own module. - CSS module usage is correctly applied and layout is visually consistent on a standard desktop resolution - The application currently runs as expected Improvements: - Responsive layout issue when reducing the browsers width the footer grid layout does not properly adapt in its current state but should be adjusted in the future. In my test 2 of the place holders were no longer visible on the smaller screen. Issues: - Comments have mixed language both Swedish and English. - There are some slight convention problem with spaces and missing semicolons (e.g missing semicolon on import { BrowserRouter .... } ) . Conclusion: the implementation technically works correctly and meets the requirements so there are no blocking issues found but it requires fixing to be regarded complete.

b24krila removed the

needs review

label

2026-04-14 13:53:24 +00:00

a24nedka commented

2026-04-14 15:42:23 +00:00

Collaborator

I can see that this PR has already been reviewed, but I have also gone through the implementation myself.

The footer is rended correctly and the component structure with CSS modules looks good.

As @b24krila mentioned about the screen, I guess it may be caused by the use of fixed spacing ( margin-left) together with (repeat(4, 1fr)) part in footer.js which may cause issues on smaller screens ( I guess).
The code standard is fulfilled for the most part , apart from smal syntax inconsistencies, such as missing semicolons.

Overall the implementation works and are good!

I can see that this PR has already been reviewed, but I have also gone through the implementation myself. The footer is rended correctly and the component structure with CSS modules looks good. As @b24krila mentioned about the screen, I guess it may be caused by the use of fixed spacing ( margin-left) together with **(repeat(4, 1fr))** part in footer.js which may cause issues on smaller screens ( I guess). The code standard is fulfilled for the most part , apart from smal syntax inconsistencies, such as missing semicolons. Overall the implementation works and are good!

b24jonel was assigned by c24elipe

2026-04-15 00:59:30 +00:00

a24vinla added the

reviewed

label

2026-04-15 06:36:55 +00:00

b24johka changed target branch from team_1_week_1 to temp-week-2-merge-branch

2026-04-15 09:16:19 +00:00