Andras/BoundlessFlowCampus2K

Fork 0

#298-update-delete-middleware #349

Merged

b24johka merged 9 commits from #298-update-delete-middleware into team_1_week_2

2026-04-17 08:09:40 +00:00

a24antej commented

2026-04-16 10:14:11 +00:00

Collaborator

Modified the middleware to be able to update and delete in the database

updated the basic structure
changed the current readmockups to use the new version
fixed bug in roombookingapimockup
instructions on how to use in README in middleware

Modified the middleware to be able to update and delete in the database - updated the basic structure - changed the current readmockups to use the new version - fixed bug in roombookingapimockup - instructions on how to use in README in middleware

🚀 1

a24antej added 5 commits

2026-04-16 10:14:11 +00:00

Update Program.cs 745a29e89f

fixed update and delete + more 1907a06e4f

have made that you can insert, update or delete a row in a database
use topic to determine database and action

Merge branch 'team_1_week_2' into #298-update-delete-middleware 4c1a57ab82

Update README.md ffbd9da926

documentation and updated README 2181da5949

a24antej added the

backEnd

API

needs review

labels

2026-04-16 10:14:40 +00:00

b24johka requested review from f21marfo

2026-04-16 11:54:37 +00:00

f21marfo requested changes

2026-04-16 13:10:15 +00:00

f21marfo left a comment

Collaborator

Review:

Code appears to follow established coding standards, new methods are have good documentation. However there is a lack of descriptive comments that explains what different sections of code are actually doing.
Main() is completely devoid of comments.

Built and test-ran application, all current app pages displaying as expected. Currently no way to test update and deletion methods, suggest creation of unit tests for the new methods.

Additional recommendations:

the if and elseif (action == ) statements in middleware/Program.cs could be more cleanly expressed as a switch statement.
Methods lack error handling
!!!UpdateMessage is not atomic, risk of race condition. Needs to be rewritten as a true SQL UPDATE-query!!!

Review: Code appears to follow established coding standards, new methods are have good documentation. However there is a lack of descriptive comments that explains what different sections of code are actually doing. Main() is completely devoid of comments. Built and test-ran application, all current app pages displaying as expected. Currently no way to test update and deletion methods, suggest creation of unit tests for the new methods. Additional recommendations: - the if and elseif (action == ) statements in middleware/Program.cs could be more cleanly expressed as a switch statement. - Methods lack error handling - !!!UpdateMessage is not atomic, risk of race condition. Needs to be rewritten as a true SQL UPDATE-query!!!

f21marfo added

reviewed

and removed

needs review

labels

2026-04-16 13:10:36 +00:00

a24antej added 1 commit

2026-04-16 13:38:13 +00:00

Merge remote-tracking branch 'origin/team_1_week_2' into #298-update-delete-middleware 5b8a7cc488

a24antej commented

2026-04-16 13:46:45 +00:00

Author

Collaborator

will try to fix everything, would appreciate if someone knew how to do the update, could not find how to update the whole row(without complex sql query)

f21marfo commented

2026-04-16 13:57:09 +00:00

Collaborator

With the current "payload" i do not believe it is even possible to do it, without a complex sql query, since we are cramming an entire row into a single string. In fact I believe that is part of the problem that issue #19 is intended to solve.

a24antej commented

2026-04-16 14:06:53 +00:00

Author

Collaborator

then i think it would be best to merg this as it is and then we could work on that on this version, i may even take on issue #19 because i have worked some with how middleware works.

a24antej added 1 commit

2026-04-17 05:56:01 +00:00

switched to using "switch case" 8a40fb52bf

a24antej added 1 commit

2026-04-17 05:56:52 +00:00

Merge remote-tracking branch 'origin/team_1_week_2' into #298-update-delete-middleware 0ab3d701dd

a24antej added 1 commit

2026-04-17 07:53:44 +00:00

Merge branch 'team_1_week_2' into #298-update-delete-middleware 7a951ff4a1

b24johka commented

2026-04-17 08:09:33 +00:00

Collaborator

I have been talking to the developer and we have decided that this pull request will spawn some new issues related to the reviewers feedback. The review has been conducted in a good fashion, this will be merged directly.

b24johka merged commit e76bc56e0d into team_1_week_2

2026-04-17 08:09:40 +00:00

b24johka referenced this pull request from a commit

2026-04-17 08:09:41 +00:00

Merge pull request '#298-update-delete-middleware' (#349) from #298-update-delete-middleware into team_1_week_2