#344 Add mqtt login #383

Merged

c24elipe merged 1 commit from #344-mqtt-login-to-use-env-file into team_2_week_2

2026-04-20 11:23:40 +00:00

j21marbr commented

2026-04-16 15:08:46 +00:00

Collaborator

Changes:

Replaced hardcoded MQTT credentials with environment variables
Updated compose file to use env variables
Added env variables to services
Added missing await to delay in readParkingApiMockup
Updated the installation scripts to generate MQTT credentials in .env

Changes: - Replaced hardcoded MQTT credentials with environment variables - Updated compose file to use env variables - Added env variables to services - Added missing await to delay in readParkingApiMockup - Updated the installation scripts to generate MQTT credentials in .env

j21marbr added 1 commit

2026-04-16 15:08:47 +00:00

Added mqtt credentials using .env c48140ebfa

j21marbr added the

needs review

label

2026-04-16 15:09:54 +00:00

j21marbr changed title from ~~Add mqtt login~~ to #344 Add mqtt login

2026-04-16 15:10:51 +00:00

j21marbr was assigned by c24elipe

2026-04-16 22:51:39 +00:00

c24elipe referenced this pull request

2026-04-17 10:29:15 +00:00

We want MQTT login to use env file #344

c24elipe requested review from b25marem

2026-04-20 08:15:48 +00:00

b25marem commented

2026-04-20 09:50:33 +00:00

Collaborator

Reviewed and partially tested locally.

MQTT credentials are now read from environment variables
No hardcoded MQTT credentials found in the reviewed files
Docker compose is updated to pass MQTT env variables
The installation script generates MQTT_USER and MQTT_PASSWORD in DockerCompose/.env
The added await fix looks correct

I could not complete the full Docker runtime test because compose stopped on an unrelated image pull issue for `parkingapimockup, but the MQTT/.env changes themselves look correct to me.

Reviewed and partially tested locally. MQTT credentials are now read from environment variables No hardcoded MQTT credentials found in the reviewed files Docker compose is updated to pass MQTT env variables The installation script generates MQTT_USER and MQTT_PASSWORD in DockerCompose/.env The added await fix looks correct I could not complete the full Docker runtime test because compose stopped on an unrelated image pull issue for `parkingapimockup, but the MQTT/.env changes themselves look correct to me.