#335-empty-card #400

Closed

b23albst wants to merge 4 commits from #335-empty-card into team_2_week_2

b23albst commented

2026-04-17 08:55:43 +00:00

Collaborator

Added the empty view with dropdown for selecting what view it should be.

It utilizes a function called replaceView that is implemented in Dashboard.js Is this the correct place to implement this function? I placed it there since it uses the setLayout function in Dashboard, but this could in theory be sent to the empty card as a parameter.

Also, the getView function could possibly be implemented in a nicer way...

Added the empty view with dropdown for selecting what view it should be. It utilizes a function called replaceView that is implemented in Dashboard.js Is this the correct place to implement this function? I placed it there since it uses the setLayout function in Dashboard, but this could in theory be sent to the empty card as a parameter. Also, the getView function could possibly be implemented in a nicer way...

b23albst added 2 commits

2026-04-17 08:55:43 +00:00

Implemented empty view card and added it and replaceCard function to dashboard eb1f7e6f6e

Changed comment to actually make sense 083076b8c7

b23albst added the

frontEnd

needs review

labels

2026-04-17 09:02:09 +00:00

b23albst was assigned by c24elipe

2026-04-20 08:47:03 +00:00

c24elipe requested review from a24danwe

2026-04-20 09:24:12 +00:00

a24danwe commented

2026-04-20 13:55:01 +00:00

Collaborator

I have reviewed all relevant files such as Dashboard.js and EmptyView.js. I have also verified that everything is implemented acording to the issue.

I have tested the implementation by going to the application and selecting the EmptyView. It renders correctly and when another view is selected in the empty view it is correctly replaced.

This is working correctly and can be merged.

I have reviewed all relevant files such as Dashboard.js and EmptyView.js. I have also verified that everything is implemented acording to the issue. I have tested the implementation by going to the application and selecting the EmptyView. It renders correctly and when another view is selected in the empty view it is correctly replaced. This is working correctly and can be merged.

a24danwe commented

2026-04-20 13:55:38 +00:00

Collaborator

On the note of getView and setView in Dashboard.js and EmptyView.js, they can be implemented in a better way, I think this has been fixed in a newer version of code so there are probably some merge conflicts.

a24danwe added

reviewed

and removed

needs review

labels

2026-04-20 13:56:02 +00:00

c24carso was assigned by c24elipe

2026-04-21 09:58:25 +00:00

c24carso added 2 commits

2026-04-21 13:00:26 +00:00

Merge branch 'team_2_week_2' into #335-empty-card dacc5863de

#335-empty-card rewrite EmptyView and merge conflict 3edd0cc74c

Resolved merge conflicts. Rewrote EmptyView to work with viewRegister instead of if/else chain. EmptyView now passes view names as strings instead of component instances.