Andras/BoundlessFlowCampus2K
3
6
Fork 0
Code Issues 143 Pull requests 14 Projects Releases Packages Wiki Activity Actions 2

refactor: separate temperature views into subfolders #425

Merged
c24elipe merged 6 commits from 409-separate-different-temperature-views into team_2_week_2 2026-04-21 12:44:29 +00:00
Conversation 6 Commits 6 Files changed 17 +108 -159
b25marem commented 2026-04-20 07:49:22 +00:00
Collaborator
Copy link

Moved each temperature view into its own directory
Moved related hooks with their respective views
Updated imports after restructuring

Moved each temperature view into its own directory Moved related hooks with their respective views Updated imports after restructuring
b24idalu requested changes 2026-04-20 09:02:45 +00:00
Dismissed
b24idalu left a comment
Collaborator
Copy link

Good breakout!

While going through the files, I noticed that the graph doesnt have correct imports (they just go to the components map instead of where to get the specific file).
The month, time-series and year folders also do not have the correct imports (too few "../", does not go back far enough to the right folders)

I tested the default view and that works perfectly.

Good breakout! While going through the files, I noticed that the graph doesnt have correct imports (they just go to the components map instead of where to get the specific file). The month, time-series and year folders also do not have the correct imports (too few "../", does not go back far enough to the right folders) I tested the default view and that works perfectly.
b25marem 2026-04-20 11:20:03 +00:00
b25marem commented 2026-04-20 11:22:37 +00:00
Author
Collaborator
Copy link

I’ve updated the imports,
could you take a look?

I’ve updated the imports, could you take a look?
b24idalu approved these changes 2026-04-20 11:33:22 +00:00
b24idalu left a comment
Collaborator
Copy link

Looks good now! The imports comment is solved as well as code standard has been strengthened.

Looks good now! The imports comment is solved as well as code standard has been strengthened.
b24idalu commented 2026-04-20 11:35:11 +00:00
Collaborator
Copy link

Quick comment to add is that settings.json has been updated, dont know if we need to push that change

Quick comment to add is that settings.json has been updated, dont know if we need to push that change
b25marem commented 2026-04-21 09:16:43 +00:00
Author
Collaborator
Copy link

I merged the latest team_2_week_2 into my branch and resolved the conflicts. The branch is now updated.

I merged the latest team_2_week_2 into my branch and resolved the conflicts. The branch is now updated.
c24elipe commented 2026-04-21 12:44:24 +00:00
Collaborator
Copy link

I have now tested this, and it compiles and seems to work!

I have now tested this, and it compiles and seems to work!
c24elipe merged commit c656bd28c9 into team_2_week_2 2026-04-21 12:44:29 +00:00
c24elipe deleted branch 409-separate-different-temperature-views 2026-04-21 12:44:30 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
b24idalu
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked-waiting-for-further-changes

   
bug

Something is not working

  
bug-only-on-server-for-mobile-not-webpage

   
Bug-Report-After-Merge

   
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
further-changes-needed

   
future-problem-not-fixint-this-period

   
help wanted

Need some help

  
invalid

Something is wrong

  
last-week-issue-to-fix

   
library

   
low-priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
not-implemented.

   
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
Script

   
security

use this for security-related issues

  
SQL

  
style

   
Team 1

Team 1 is responsible for this issue

  
Team 2

Team 2 is responsible for this issue

  
team leaders

   
test-creation

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
unassigned

   
Under-review

   
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
b25marem
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!425
No description provided.