Andras/BoundlessFlowCampus2K

Fork 0

#429-add-selectables-year-month-temp #441

Closed

a24julot wants to merge 0 commits from #429-add-selectables-year-month-temp into team_1_week_2

a24julot commented

2026-04-20 11:38:39 +00:00

Collaborator

Added the ability to choose year and month, with the default year and month being the present.

tempview.png

31 KiB

a24julot added 3 commits

2026-04-20 11:38:40 +00:00

Added the function to change the year c04259e327

Added the function to change month and year 9d87019392

Removed hardcoded year and month 63537e316a

a24julot referenced this pull request

2026-04-20 11:38:54 +00:00

Add selectables to tempService year, month and week #429

b24hugst added 1 commit

2026-04-20 13:02:52 +00:00

Update month/year cache b20c9e8176

Fixed so average temperature from 2026 is not shown on all years in /month/year

b24hugst commented

2026-04-20 13:06:19 +00:00

Collaborator

I fixed so it now doesn't always show 2026 results in /month/year

The problem was that I had written the cache-key incorrectly. So it requested from the 2026-cache at all times.

I fixed so it now doesn't always show 2026 results in **/month/year** The problem was that I had written the cache-key incorrectly. So it requested from the 2026-cache at all times.

👍 1

b24johka

2026-04-21 07:22:33 +00:00

added the
Team 1
label
requested review from a24hamrh

a24julot added the

needs review

label

2026-04-21 08:50:44 +00:00

a24hamrh commented

2026-04-21 11:48:17 +00:00

Collaborator

Review on #441

Whats done

Reviewed #441

Tested on Windows 11 using Firefox

App starts
- Tested adding the month view and year view. Tried changing month and year. Works as expected on both.

Inspected following files Dashboard.js, TemperatureMonthView.js, TemperatureYearView.js, TemperatureByMonth.js, TemperatureByYear.js

All files inspected
- Indentation/code styling follows prettier
  - Writes Indentation is ok
- Naming convention
  - The Naming convention is followed and looks good.
- Comments
  - Comments are good
- General code quality
  - The general quality is good.

Conclusion

The file executes as expected and everything works as intended. The code looks good and the styling follows prettier.

# Review on #441 ## Whats done Reviewed #441 ### Tested on Windows 11 using Firefox + App starts + Tested adding the month view and year view. Tried changing month and year. Works as expected on both. ### Inspected following files Dashboard.js, TemperatureMonthView.js, TemperatureYearView.js, TemperatureByMonth.js, TemperatureByYear.js + All files inspected + Indentation/code styling follows prettier + Writes Indentation is ok + Naming convention + The Naming convention is followed and looks good. + Comments + Comments are good + General code quality + The general quality is good. ## Conclusion + The file executes as expected and everything works as intended. The code looks good and the styling follows prettier.