Andras/BoundlessFlowCampus2K

Fork 0

428-text-card-to-notes #449

Merged

b24johka merged 5 commits from 428-text-card-to-notes into team_1_week_2

2026-04-21 08:20:43 +00:00

b24erika commented

2026-04-20 12:45:12 +00:00

Collaborator

Changed old text view, not using textarea-tag instead off input-tag. After some discussion with team leaders we decided to go with edit/erase button on the view instead off the dashboard edit button.

Also changed the Card component, there was an unnecessary div-tag making views not to scale with the parent.

There is a function that makes editing false when pressing enter, this function existed before I worked on the file. I do think that it can be somewhat negative to have false on an enter "stroke", users may want to have a new lines in the notes but did not do any changes to it.

Changed old text view, not using textarea-tag instead off input-tag. After some discussion with team leaders we decided to go with edit/erase button on the view instead off the dashboard edit button. Also changed the Card component, there was an unnecessary div-tag making views not to scale with the parent. There is a function that makes editing false when pressing enter, this function existed before I worked on the file. I do think that it can be somewhat negative to have false on an enter "stroke", users may want to have a new lines in the notes but did not do any changes to it.

b24erika added 4 commits

2026-04-20 12:45:12 +00:00

Initial version of textarea 95a38f5625

Fixed so the text-area expands as card 9fd779ba7c

found the issue why text displayed outside of card, trying to resolve a better approach

Added button for edit and erase all 5938baefa7

To edit you now have to press the button also implemented a remove all button if you want a fresh note

added comments d33c145afc

b24erika added the

frontEnd

needs review

labels

2026-04-20 12:45:35 +00:00

b24erika self-assigned this

2026-04-20 12:45:36 +00:00

b24erika referenced this pull request

2026-04-20 12:49:19 +00:00

Make text-card to be more note-like. #428

b24erika commented

2026-04-20 12:51:45 +00:00

Author

Collaborator

This pull-request is related to three issues: 428, 412 and 395.

This pull-request is related to three issues: [428](https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/428), [412](https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/412) and [395](https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/395).

b24erika referenced this pull request

2026-04-20 13:05:30 +00:00

Add the functionality to erase the body and title of the textCard #412

b24erika referenced this pull request

2026-04-20 13:12:35 +00:00

Text should only be editable in edit mode for text card #395

b24johka requested review from a24julot

2026-04-21 07:04:59 +00:00

b24erika added 1 commit

2026-04-21 08:01:04 +00:00

readonly instead of disabled cfc54fcc5b

a24julot commented

2026-04-21 08:11:19 +00:00

Collaborator

Review on issue #428

Whats done

Tested if the textarea scaled with the card.
- Works as intended.
Tested the "save", "edit" and "erase all" buttons.
- Works as intended.

Inspected following files:

features/text/Text.module.css
features/text/TextView.js
- Naming conventions
  - Naming conventions followed.
- Comments
  - Descriptive comments.
- General code quality
  - No issues found.
  - Good code quality.

Conclusion

The issue has been resolved.
One thing that is also mention by @b24erika is that when pressing enter the text is simply saved, meaning that the user cannot press enter to skip to the next line. This is not necessarily an issue but is worth mentioning.

# Review on issue https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/428 ## Whats done - Tested if the textarea scaled with the card. - Works as intended. - Tested the "save", "edit" and "erase all" buttons. - Works as intended. ### Inspected following files: - features/text/Text.module.css - features/text/TextView.js - Naming conventions - Naming conventions followed. - Comments - Descriptive comments. - General code quality - No issues found. - Good code quality. ## Conclusion - The issue has been resolved. - One thing that is also mention by @b24erika is that when pressing enter the text is simply saved, meaning that the user cannot press enter to skip to the next line. This is not necessarily an issue but is worth mentioning.