Update Grid (Dashboard.js) #482

Closed
a24nedka wants to merge 17 commits from #452-Grid-background-does-not-expand-with-grid into team_2_week_2
Collaborator

Grid background now expands dynamically based on the lowest positioned item in the layout.

-Grid background was previously fixed to a static number of rows, which caused it to not expand when dragging cards further down. This have been updated so that the number of rows is now calculated dynamically. As the result, the grid background expands when cards are dragged down and shrinks again when they are moved back up.

-This make sure that the grid matches the visible layout.

-"TemperatureAllView" was temporarily removed due to a runtime error.

Screenshot:
imageimage

Grid background now expands dynamically based on the lowest positioned item in the layout. -Grid background was previously fixed to a static number of rows, which caused it to not expand when dragging cards further down. This have been updated so that the number of rows is now calculated dynamically. As the result, the grid background expands when cards are dragged down and shrinks again when they are moved back up. -This make sure that the grid matches the visible layout. -"TemperatureAllView" was temporarily removed due to a runtime error. Screenshot: ![image](/attachments/55d04ccb-aa48-487c-be20-c30cbd631815)![image](/attachments/fb332056-42fd-45a4-8e27-9e0cc9bdf84c)
Grid background now expands dynamically based on the lowest positioned item in the layout. “Removed TemperatureAllView temporarily due to "runtime error”
Author
Collaborator

issue :
#452

issue : https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/452
Collaborator

Review on #452

Whats done

Tested on Windows using Firefox

  • App starts
    • Grid background expands when dragging cards down
    • Grid background shrinks when moving cards back up( to a certain limit)

Inspected following files

  • frontend/src/components/Dashboard/Dashboard.js
    • Indentation/code styling
      • Follows Prettier
    • Naming convention
      • Follows wiki standards
    • Comments
      • Comment added for dynamicRows calculation
    • General code quality
      • No issues found
  • frontend/package.json
    • No new dependencies added

What needs to be done

  • Nothing

Conclusion

  • Grid background now expands and shrinks as cards are pulled down or up. Code follows project standards and is ready to merge.
# Review on #452 ## Whats done ### Tested on Windows using Firefox + App starts + Grid background expands when dragging cards down + Grid background shrinks when moving cards back up( to a certain limit) ### Inspected following files + frontend/src/components/Dashboard/Dashboard.js + Indentation/code styling + Follows Prettier + Naming convention + Follows wiki standards + Comments + Comment added for dynamicRows calculation + General code quality + No issues found + frontend/package.json + No new dependencies added ## What needs to be done + Nothing ## Conclusion + Grid background now expands and shrinks as cards are pulled down or up. Code follows project standards and is ready to merge.
Collaborator

Merged manually, closing now!

Merged manually, closing now!
a24vinla closed this pull request 2026-04-22 06:20:44 +00:00

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!482
No description provided.