Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

#507-breakout-danger-modal #520

Closed
e24aleli wants to merge 0 commits from #507-breakout-danger-modal into team_1_week_3
pull from: #507-breakout-danger-modal
merge into: Andras:team_1_week_3
Conversation 9 Commits - Files changed -
e24aleli commented 2026-04-23 12:19:19 +00:00
Collaborator
Copy link

Made a new directory called DangerModal that holds the button logic and css for both the modal and the button.

Also cleaned up remainders of the previous reset button that was in dashboard.js

Made a new directory called DangerModal that holds the button logic and css for both the modal and the button. Also cleaned up remainders of the previous reset button that was in dashboard.js
This reverts commit 18801ff6f6.
Reviewed-on: #511
Reviewed-by: Tim Svensson <a24timsv@noreply.localhost>
f21marfo reviewed 2026-04-23 13:13:12 +00:00
f21marfo left a comment
Collaborator
Copy link

Review on #507

Whats done

Tested on Windows 11 25H2 using Edge

  • [Focus on checking features that the issue intended to solve/implement]
  • App starts [IF the app starts]
    • App loads and runs as expected.
    • Added widgets and clicked the "reset" button, appears to function as expected.

Inspected following files

  • Dashboard.module.css
    • General code quality
      • Code changes to not appear relevant to the Issue.
  • index.js
    • General code quality
      • Single code line conforms identically to the rest of the code in this file, on all points.
  • Dashboard.js
    • Indentation/code styling
      • Mostly good, use of DangerModal component has indendtation issue at line 204.
    • Naming convention
      • Checks out.
    • General code quality
      • Use of DangerModal could be cleaner with the use of a self closing tag instead of .
  • DangerModal.module.css
    • No comment really, it's a cut-and-paste of existing code in Dashboard.module.css.
  • DangerModal.js
    • Indentation/code styling
      • Looks Ok.
    • Naming convention [Including filename ]
      • Looks Ok.
    • Comments
      • Looks Ok.

What needs to be done

[Here you should write the things that needs to be fixed.]

  • Dashboard.module.css
    • These changes are not relevant to the issue and need to be omitted.

Conclusion

  • Code mostly looks good if the intent is for the entire modal is meant to be broken out and not just the button. Commits not related to the issue need to be omitted before merge.
# Review on #507 ## Whats done ### Tested on Windows 11 25H2 using Edge + [Focus on checking features that the issue intended to solve/implement] + App starts [IF the app starts] + App loads and runs as expected. + Added widgets and clicked the "reset" button, appears to function as expected. ### Inspected following files + Dashboard.module.css + General code quality + Code changes to not appear relevant to the Issue. + index.js + General code quality + Single code line conforms identically to the rest of the code in this file, on all points. + Dashboard.js + Indentation/code styling + Mostly good, use of DangerModal component has indendtation issue at line 204. + Naming convention + Checks out. + General code quality + Use of DangerModal could be cleaner with the use of a self closing tag instead of </DangerModal>. + DangerModal.module.css + No comment really, it's a cut-and-paste of existing code in Dashboard.module.css. + DangerModal.js + Indentation/code styling + Looks Ok. + Naming convention [Including filename ] + Looks Ok. + Comments + Looks Ok. ## What needs to be done [Here you should write the things that needs to be fixed.] + Dashboard.module.css + These changes are not relevant to the issue and need to be omitted. ## Conclusion + Code mostly looks good if the intent is for the entire modal is meant to be broken out and not just the button. Commits not related to the issue need to be omitted before merge.
b24johka commented 2026-04-23 16:24:15 +00:00
Collaborator
Copy link

I dont think .toolbar and .toolbarcontainer in the CSS file is related to the component, it should probably be removed

I dont think .toolbar and .toolbarcontainer in the CSS file is related to the component, it should probably be removed
e24aleli commented 2026-04-23 16:35:28 +00:00
Author
Collaborator
Copy link

The toolbar classes are for the button i was thinking of importing the css file that dashboard uses but thought it would cause problems maybe i should just rename them?

The toolbar classes are for the button i was thinking of importing the css file that dashboard uses but thought it would cause problems maybe i should just rename them?
b24johka commented 2026-04-24 07:04:16 +00:00
Collaborator
Copy link

as long as the danger button is inside .toolbar and .toolbarcontainer classes in the code they should just go under dashboard.module.css? I will try this out and see if this is the case.

as long as the danger button is inside .toolbar and .toolbarcontainer classes in the code they should just go under dashboard.module.css? I will try this out and see if this is the case.
👍 1
b24johka commented 2026-04-27 07:49:44 +00:00
Collaborator
Copy link

I tried the mention above and it works good, break it out of the CSS class please since it belongs to dashboard.module.css

I tried the mention above and it works good, break it out of the CSS class please since it belongs to dashboard.module.css
b24johka requested changes 2026-04-27 07:51:11 +00:00
b24johka left a comment
Collaborator
Copy link

Remove toolbar related items

Remove toolbar related items
e24aleli commented 2026-04-27 08:29:56 +00:00
Author
Collaborator
Copy link

I removed the CSS inside of DangerModal file, seems to work.

I removed the CSS inside of DangerModal file, seems to work.
b24johka commented 2026-04-28 08:12:56 +00:00
Collaborator
Copy link

This has been manually merged as the review is sufficient for this PR. Good job!

This has been manually merged as the review is sufficient for this PR. Good job!
b24johka commented 2026-04-28 08:13:50 +00:00
Collaborator
Copy link

On a second notice i have seen that the dark overlay from the modal is not active when modal pops up. This will be a seperate issue and PR.

On a second notice i have seen that the dark overlay from the modal is not active when modal pops up. This will be a seperate issue and PR.
b24johka closed this pull request 2026-04-28 08:13:54 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
b24johka
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!520
No description provided.