#377 implement sudoku view #536
c22abdal
a24nedka
a24vinla
Labels
No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
No milestone
No project
No assignees
5 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Andras/BoundlessFlowCampus2K!536
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "#377-Implement-Sudoku-View"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Regarding issue #377: creating a sudoku view.
Problems: 1. Create a sudoku game, 2. Add it as a view
Solution: 1. Created a sudoku game by using a temporary API called dosuku which generates a gameboard. Game functions was after that added to make sure people could place numbers, not delete original number, place notes and see errors if they so wish. 2. A view is created for the sudoku, but as it was deemed to be possibly to small for people to see what was going on, it was made to open a modal that contains the sudoku.
Possible improvements:
I added a comment with possible todos in the sudokuModal.js file, but to sum it up possible features could be;
- Adding a timer
- Highlight more stuff such as all cells that are the same number as the selected one OR highlighting all cells where the number is blocking (such as row, column, box).
- Add difficulties (right now a random difficulty is generates since the used API does not have an option for difficulty (I think), this means a new api would need to be found, more comments about this in the issue)
Input would be good:
- If the modal is the right size or if it should be bigger/smaller
- How to make it look nicer
- If any more text needs to be added (for example game description, or something else)
Review
The game works as intended. Personally, I think it needs more polish, but it does the job.
One thing to change is the button
It is misleading, as it does not open a new game it just opens the last game created. So change the button to something like: Open sudoku window or open game. and make the view name to Sudoku
Make it look nicer
This part is maybe unnecessary? However, in my perspective:
but this is risky where the user might not understand, so choose wisely, young one!
As I thought that buttons and text below could look too clustered, I decided to test both and compare them side to side. The one with text below also has a bigger grid. **Note that the slide text should be above the buttons but missed it when I took a picture
10/10 would play again!
Review on #377
Whats done
Tested on Windows using Chrome
-Focused on testing the Sudoku view functionality and layout changes from the previous review
-App starts
-No errors detected
-Sudoku grid renders correctly.
-Checked layout changes => text is now below the grid.
Inspected following files
sudokuModal.js
sudokuModa.module.css
Indentation/code styling
-Indentation is consistent and follows standard formatting
-Naming convention
-Naming is clear and follows conventions
-File and function names are descriptive
-Comments are present and helpful
-Code is readable and structured
-No obvious unnecessary complexity
-No unused imports detected
What needs to be done
-The “New Game” button is not visible in light mode, a small styling adjustment is needed to ensure visibility in both light and dark mode
Conclusion
The implementation fulfills the requirements and addresses the feedback from the previous review. Only a minor UI issue remains (button visibility in light mode). Good job!
Merged this manually, well done everyone!
Pull request closed