Andras/BoundlessFlowCampus2K
3
6
Fork 0
Code Issues 141 Pull requests 15 Projects Releases Packages Wiki Activity Actions 2

#377 implement sudoku view #536

Closed
b24idalu wants to merge 0 commits from #377-Implement-Sudoku-View into team_2_week_3
pull from: #377-Implement-Sudoku-View
merge into: Andras:team_2_week_3
Conversation 6 Commits - Files changed -
b24idalu commented 2026-04-24 08:00:46 +00:00
Collaborator
Copy link

Regarding issue #377: creating a sudoku view.

Problems: 1. Create a sudoku game, 2. Add it as a view

Solution: 1. Created a sudoku game by using a temporary API called dosuku which generates a gameboard. Game functions was after that added to make sure people could place numbers, not delete original number, place notes and see errors if they so wish. 2. A view is created for the sudoku, but as it was deemed to be possibly to small for people to see what was going on, it was made to open a modal that contains the sudoku.

Possible improvements:
I added a comment with possible todos in the sudokuModal.js file, but to sum it up possible features could be;
- Adding a timer
- Highlight more stuff such as all cells that are the same number as the selected one OR highlighting all cells where the number is blocking (such as row, column, box).
- Add difficulties (right now a random difficulty is generates since the used API does not have an option for difficulty (I think), this means a new api would need to be found, more comments about this in the issue)

Input would be good:
- If the modal is the right size or if it should be bigger/smaller
- How to make it look nicer
- If any more text needs to be added (for example game description, or something else)

Regarding issue [#377](https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/377): creating a sudoku view. Problems: 1. Create a sudoku game, 2. Add it as a view Solution: 1. Created a sudoku game by using a temporary API called dosuku which generates a gameboard. Game functions was after that added to make sure people could place numbers, not delete original number, place notes and see errors if they so wish. 2. A view is created for the sudoku, but as it was deemed to be possibly to small for people to see what was going on, it was made to open a modal that contains the sudoku. Possible improvements: I added a comment with possible todos in the sudokuModal.js file, but to sum it up possible features could be; - Adding a timer - Highlight more stuff such as all cells that are the same number as the selected one OR highlighting all cells where the number is blocking (such as row, column, box). - Add difficulties (right now a random difficulty is generates since the used API does not have an option for difficulty (I think), this means a new api would need to be found, more comments about this in the issue) Input would be good: - If the modal is the right size or if it should be bigger/smaller - How to make it look nicer - If any more text needs to be added (for example game description, or something else)
Added sudoku view that was created on earlier branch (#377-sudoku-view) and tested to make sure everything still works.
c22abdal commented 2026-04-24 09:16:25 +00:00
Collaborator
Copy link

Review

The game works as intended. Personally, I think it needs more polish, but it does the job.

One thing to change is the button
image
It is misleading, as it does not open a new game it just opens the last game created. So change the button to something like: Open sudoku window or open game. and make the view name to Sudoku

Make it look nicer

This part is maybe unnecessary? However, in my perspective:

  • Place the text on the bottom
    image
  • Make the game window take the full width so it bigger in size
    image
  • Keep the buttons underneath the game window
    image
  • Rename the title of the text to Sudoku rules: and size it down a bit.
  • Make the buttons white and add icons if possible.(ex: for the note taking add a note-taking icon, and for the num input add a number icon.)
    but this is risky where the user might not understand, so choose wisely, young one!
## Review The game works as intended. Personally, I think it needs more polish, but it does the job. One thing to change is the button ![image](/attachments/446b9b8a-a396-4c4e-a6b1-586152011e5e) It is misleading, as it does not open a new game it just opens the last game created. So change the button to something like: Open sudoku window or open game. and make the **view name** to _Sudoku_ ### Make it look nicer This part is maybe unnecessary? However, in my perspective: - Place the text on the bottom ![image](/attachments/ac881022-564b-4f44-a108-b46df631874b) - Make the game window take the full width so it bigger in size ![image](/attachments/d9d7c271-1880-490c-8334-6269f9755f34) - Keep the buttons underneath the game window ![image](/attachments/778b894d-8a81-4d12-bc38-1ba599e4b298) - Rename the title of the text to _**Sudoku rules:**_ and size it down a bit. - Make the buttons white and add icons if possible.(ex: for the note taking add a note-taking icon, and for the num input add a number icon.) but this is risky where the user might not understand, so choose wisely, young one!
image.png
4.4 KiB
image.png
34 KiB
image.png
30 KiB
image.png
31 KiB
b24idalu commented 2026-04-24 11:08:52 +00:00
Author
Collaborator
Copy link

image
image

As I thought that buttons and text below could look too clustered, I decided to test both and compare them side to side. The one with text below also has a bigger grid. **Note that the slide text should be above the buttons but missed it when I took a picture

![image](/attachments/e17b773b-8080-4c74-b7e2-f0d0946420bf) ![image](/attachments/8487d3d0-7cb7-400f-81b5-1d40003a7253) As I thought that buttons and text below could look too clustered, I decided to test both and compare them side to side. The one with text below also has a bigger grid. **Note that the slide text should be above the buttons but missed it when I took a picture
image.png
36 KiB
image.png
34 KiB 
Added reviewed comments
c24danli commented 2026-04-27 13:47:44 +00:00
Collaborator
Copy link

10/10 would play again!
image

10/10 would play again! ![image](/attachments/8d08e08a-c645-4ab0-a28c-84d9b2db7832)
image.png
42 KiB
a24nedka commented 2026-04-28 08:05:34 +00:00
Collaborator
Copy link

Review on #377

Whats done

Tested on Windows using Chrome

-Focused on testing the Sudoku view functionality and layout changes from the previous review

-App starts

-No errors detected

-Sudoku grid renders correctly.

-Checked layout changes => text is now below the grid.

Inspected following files

sudokuModal.js
sudokuModa.module.css

Indentation/code styling

-Indentation is consistent and follows standard formatting

-Naming convention

-Naming is clear and follows conventions

-File and function names are descriptive

-Comments are present and helpful

-Code is readable and structured

-No obvious unnecessary complexity

-No unused imports detected

What needs to be done

-The “New Game” button is not visible in light mode, a small styling adjustment is needed to ensure visibility in both light and dark mode
image image

Conclusion

The implementation fulfills the requirements and addresses the feedback from the previous review. Only a minor UI issue remains (button visibility in light mode). Good job!

# Review on #377 ## Whats done ### Tested on Windows using Chrome -Focused on testing the Sudoku view functionality and layout changes from the previous review -App starts -No errors detected -Sudoku grid renders correctly. -Checked layout changes => text is now below the grid. ### Inspected following files sudokuModal.js sudokuModa.module.css ### Indentation/code styling -Indentation is consistent and follows standard formatting -Naming convention -Naming is clear and follows conventions -File and function names are descriptive -Comments are present and helpful -Code is readable and structured -No obvious unnecessary complexity -No unused imports detected ## What needs to be done -The “New Game” button is not visible in light mode, a small styling adjustment is needed to ensure visibility in both light and dark mode ![image](/attachments/99a8bde7-886d-45fe-9932-8fb28db3df67) ![image](/attachments/355db2f4-01e9-4a60-a005-140fb9bcc0ee) ## Conclusion The implementation fulfills the requirements and addresses the feedback from the previous review. Only a minor UI issue remains (button visibility in light mode). Good job!
image.png
52 KiB
image.png
52 KiB
image.png 
Fixed button color to work with different themes and lightmode.
a24vinla approved these changes 2026-04-29 06:27:49 +00:00
a24vinla commented 2026-04-29 06:30:09 +00:00
Collaborator
Copy link

Merged this manually, well done everyone!

Merged this manually, well done everyone!
a24vinla closed this pull request 2026-04-29 06:30:12 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
c22abdal
a24nedka
a24vinla
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked-waiting-for-further-changes

   
bug

Something is not working

  
bug-only-on-server-for-mobile-not-webpage

   
Bug-Report-After-Merge

   
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
further-changes-needed

   
future-problem-not-fixint-this-period

   
help wanted

Need some help

  
invalid

Something is wrong

  
last-week-issue-to-fix

   
library

   
low-priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
not-implemented.

   
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
Script

   
security

use this for security-related issues

  
SQL

  
style

   
Team 1

Team 1 is responsible for this issue

  
Team 2

Team 2 is responsible for this issue

  
team leaders

   
test-creation

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
unassigned

   
Under-review

   
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked-waiting-for-further-changes
bug
bug-only-on-server-for-mobile-not-webpage
Bug-Report-After-Merge
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
further-changes-needed
future-problem-not-fixint-this-period
help wanted
invalid
last-week-issue-to-fix
library
low-priority
needs input
needs review
not-implemented.
project documentation
question
research
reviewed
Script
security
SQL
style
Team 1
Team 2
team leaders
test-creation
testing
topLevel
unassigned
Under-review
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
b24idalu
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!536
No description provided.