Andras/BoundlessFlowCampus2K

Fork 0

474 implement login modal #566

Merged

c24elipe merged 3 commits from 474-implement-login-modal into team_2_week_3

2026-04-28 07:31:07 +00:00

b25marem commented

2026-04-27 06:20:38 +00:00

Collaborator

Implements login modal (#474)
Login modal is shown when the page loads
Reused existing LoginModal component
Replaced hook-based logic with props (showLoginModal, onClose)
Guest button closes the modal
Login and Forgot password show temporary messages
Modal closes on ESC and when clicking outside

No backend integration included yet.

Implements login modal (#474) Login modal is shown when the page loads Reused existing LoginModal component Replaced hook-based logic with props (showLoginModal, onClose) Guest button closes the modal Login and Forgot password show temporary messages Modal closes on ESC and when clicking outside No backend integration included yet.

b25marem added 1 commit

2026-04-27 06:20:39 +00:00

474 implement login modal c613b3224c

b25marem was assigned by c24elipe

2026-04-27 08:55:04 +00:00

c24elipe requested review from c24danli

2026-04-27 09:00:22 +00:00

c24danli requested changes

2026-04-27 09:59:41 +00:00

c24danli left a comment

Collaborator

Review on #474

Whats done

Tested on Windows 11 using Edge/Chrome

App starts and Login shown
- Currently the Guest button looks good but login needs to have the same standard(diffrent color from background) look picture.
- Tested closing the popup in the diffrent ways "esq", clicking outside of popup and using Guest, all works well.
- Tested the "login" and "forgot password" works as intended at the moment, shows a massage that its not implimented.

Inspected following files

App.js
- Indentation/code styling
  - Exist no standard for js in wiki but follows prettier.
- Naming convention
  - Name convention is followed.
- Comments
  - No comments but App.js is easy to read without.
- General code quality
  - Good.
frontend/src/features/login/LoginModal.js
- Indentation/code styling
  - Exist no standard for js in wiki but follows prettier.
- Naming convention
  - Good previus names have been uppdated to names that describe functionallity better
    export default function LoginModal(hook) { to
    export default function LoginModal({ showLoginModal, onClose })
- Comments
  - Good amount of comments in code, short and describing. One of the comments is of a diffrent style(C comment) when its a single line comment. Line 5 /* LoginModal renders a centered overlay modal with login and guest access options */ use // insted
- General code quality
  - Good.

What needs to be done

frontend/src/features/login/LoginModal.js
- Add the same css to "login" as "guest" button.
- minor change to comment style /*....*/ to // line 5

Conclusion

Good overall, minor changes before its readdy to merge

# Review on #474 ## Whats done ### Tested on Windows 11 using Edge/Chrome + App starts and Login shown + Currently the Guest button looks good but login needs to have the same standard(diffrent color from background) look picture. ![image](/attachments/2c50ec8e-b873-48b2-8381-7b39cbe49fc8) + Tested closing the popup in the diffrent ways "esq", clicking outside of popup and using Guest, all works well. + Tested the "login" and "forgot password" works as intended at the moment, shows a massage that its not implimented. ### Inspected following files + App.js + Indentation/code styling + Exist no standard for js in wiki but follows prettier. + Naming convention + Name convention is followed. + Comments + No comments but App.js is easy to read without. + General code quality + Good. + frontend/src/features/login/LoginModal.js + Indentation/code styling + Exist no standard for js in wiki but follows prettier. + Naming convention + Good previus names have been uppdated to names that describe functionallity better `export default function LoginModal(hook) {` to `export default function LoginModal({ showLoginModal, onClose })` + Comments + Good amount of comments in code, short and describing. One of the comments is of a diffrent style(C comment) when its a single line comment. Line 5` /* LoginModal renders a centered overlay modal with login and guest access options */` use `//` insted + General code quality + Good. ## What needs to be done + frontend/src/features/login/LoginModal.js + Add the same css to "login" as "guest" button. + minor change to comment style` /*....*/` to `//` line 5 ## Conclusion + Good overall, minor changes before its readdy to merge

image.png

44 KiB

b25marem added 1 commit

2026-04-27 13:31:04 +00:00

Fix login modal review comments ee5703468b

b25marem commented

2026-04-27 13:31:49 +00:00

Author

Collaborator

Fixed review comments:
Updated comment style to //
Made Login button use same styling as Guest button

Fixed review comments: Updated comment style to // Made Login button use same styling as Guest button

a24vinla added the

reviewed

label

2026-04-28 06:45:11 +00:00

a24vinla approved these changes

2026-04-28 06:45:29 +00:00

c24elipe added 1 commit

2026-04-28 07:30:43 +00:00

Merge remote-tracking branch 'origin/team_2_week_3' into 474-implement-login-modal f581bea3ae

c24elipe commented

2026-04-28 07:30:58 +00:00

Collaborator

It compiles and runs. But the buttons need to be updated in the future. Get merged

![image](/attachments/3f686aca-d292-4de0-9399-76237732360a) It compiles and runs. But the buttons need to be updated in the future. Get merged

image.png

22 KiB

c24elipe merged commit d096698f99 into team_2_week_3

2026-04-28 07:31:07 +00:00

c24elipe referenced this pull request from a commit

2026-04-28 07:31:08 +00:00

Merge pull request '474 implement login modal' (#566) from 474-implement-login-modal into team_2_week_3

c24elipe deleted branch 474-implement-login-modal

2026-04-28 07:31:10 +00:00

b25marem commented

2026-05-06 07:00:03 +00:00

Author

Collaborator

This PR can be closed now.

Before closing it completely, please create a new issue for the remaining login modal behavior:

The login modal should not appear again after refreshing the page once the user has chosen to continue as guest or logged in.
When the login modal is open, the user should not be able to interact with other buttons or elements behind the modal.

The current PR is merged and reviewed, so these remaining improvements can be handled in a separate issue.

This PR can be closed now. Before closing it completely, please create a new issue for the remaining login modal behavior: The login modal should not appear again after refreshing the page once the user has chosen to continue as guest or logged in. When the login modal is open, the user should not be able to interact with other buttons or elements behind the modal. The current PR is merged and reviewed, so these remaining improvements can be handled in a separate issue.

b25marem referenced this pull request from a commit

2026-05-15 08:56:02 +00:00

Merge pull request '474 implement login modal' (#566) from 474-implement-login-modal into team_2_week_3