Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

524-Change-background-of-temperature-card #572

Merged
c24elipe merged 10 commits from 524-Change-background-of-temperature-card into team_2_week_3 2026-04-27 11:11:58 +00:00
Conversation 7 Commits 10 Files changed 9 +61 -15
c24danli commented 2026-04-27 08:33:37 +00:00
Collaborator
Copy link

To test diffrent pictures you can change const bgimg = getImageBg(temp); temp to a specific calue in SMHITempratureView.js

To test diffrent pictures you can change `const bgimg = getImageBg(temp);` temp to a specific calue in SMHITempratureView.js
Added a picture(cant be used later for legal resons)
added a function to choose picture based on temp, might be changed to use SMHI's weather codes for better match.
added to card to be able to accept background aswell.
Card.js: add parameter className witch adds recived css to the curently used style.card.
getImageBg.js: decides witch css to use in SMHITemperatureView.
module.css: removed inline and put it in css file.
View.js : removed inline for the img

Left: remove other inline styles,
add remaining temp pictures,
Make it more dynamic then just hot,cold & mild
Might have to think about how to display the text nicely, depending on user settings it can be hard to see. having the text color hardcoded is an option but can make it feel strange when other views change but not this one
Changes:
-have addded 3 jpg pictures in src\assests that can be used now.
- getImageBg is just a function that chose the img to use
- SMHITempratureView have removed all onld inline and changed to css and it sends with the css backround-image to be used by card.js
- and added a css file for the view
- samll change in Card.js to accept additional css for background-image mostly
c24elipe reviewed 2026-04-27 08:42:16 +00:00
frontend/src/features/smhi/SMHITemperatureView.js Outdated
@ -3,3 +4,4 @@
import { useSMHIObservations } from './useSMHIObservations';
import { getImageBg } from './getImageBg';
// THIS IS A DEMO FILE
c24elipe commented 2026-04-27 08:42:16 +00:00
Collaborator
Copy link

REMOVE!!!!

REMOVE!!!!
c24elipe reviewed 2026-04-27 08:43:36 +00:00
c24elipe left a comment
Collaborator
Copy link

Looks good at a first glance. Will now pull down and try it out.

Looks good at a first glance. Will now pull down and try it out.
added hexcodes insted of "white",
and removed some old comments
c24elipe commented 2026-04-27 09:28:54 +00:00
Collaborator
Copy link

Comment spacing in card.js
Remove 0rem from the other CSS file
Rename bgimg to bgImg

Remove unused import in frontend/src/features/smhi/getImageBg.js

(Review done in person)

Comment spacing in card.js Remove 0rem from the other CSS file Rename bgimg to bgImg Remove unused import in frontend/src/features/smhi/getImageBg.js (Review done in person)
c24elipe requested changes 2026-04-27 10:09:26 +00:00
c24elipe left a comment
Collaborator
Copy link

See comment for what to change

See comment for what to change
In person review, and fixes of the code.
changed the naming convention and removed unnassesary coments and old imports
c24danli commented 2026-04-27 10:26:07 +00:00
Author
Collaborator
Copy link

Chages implimented from review, ready for re-review for merge

Chages implimented from review, ready for re-review for merge
c24elipe commented 2026-04-27 11:11:51 +00:00
Collaborator
Copy link

Good enough. Some cleanup needs to be done. (In a future PR/issue)

Good enough. Some cleanup needs to be done. (In a future PR/issue)
c24elipe merged commit 3397ed6b66 into team_2_week_3 2026-04-27 11:11:58 +00:00
c24elipe deleted branch 524-Change-background-of-temperature-card 2026-04-27 11:12:00 +00:00
c24danli commented 2026-05-04 11:14:52 +00:00
Author
Collaborator
Copy link

As its merged i will close this and open new issues

As its merged i will close this and open new issues
Sign in to join this conversation.
Reviewers
No reviewers
c24elipe
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
c24danli
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!572
No description provided.