#369-implement-hamburger-menu #587

Closed
a24julot wants to merge 0 commits from #369-implement-hamburger-menu into team_1_week_3
Collaborator

Made a hamburger menu for settings. Can add more choices when necessary.

Made a hamburger menu for settings. Can add more choices when necessary.
Collaborator

What has been reviewed?

  • The coding standard is being followed
  • It is what we have requested

However, the hamburger menu doesnt seem responsive in a few areas (See screenshot)

  • The Menu is really big when on a mobile device (Should probably scale down to take up max 50% of screen)
  • The Menu is not aligned with the navbar.
  • The text wont scale down (This might be because REM is relative to parent container, if parent stay the same it will stay the same)

The screenshot is taken through an Iphone 14

**What has been reviewed?** - The coding standard is being followed - It is what we have requested **However, the hamburger menu doesnt seem responsive in a few areas (See screenshot)** - The Menu is really big when on a mobile device (Should probably scale down to take up max 50% of screen) - The Menu is not aligned with the navbar. - The text wont scale down (This might be because REM is relative to parent container, if parent stay the same it will stay the same) The screenshot is taken through an Iphone 14
Author
Collaborator

I am not sure if we are supposed to develop for mobile devices in the same files that we develop for desktop. I saw that there is a question on how we should approach this to the customer in issue #600. So I am not sure what needs to be done at this moment. Will wait for customer feedback.

I am not sure if we are supposed to develop for mobile devices in the same files that we develop for desktop. I saw that there is a question on how we should approach this to the customer in issue https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/600. So I am not sure what needs to be done at this moment. Will wait for customer feedback.
Collaborator
https://www.w3schools.com/css/css_rwd_mediaqueries.asp
Author
Collaborator

This has been updated and it should now scale appropriately.

This has been updated and it should now scale appropriately.
Collaborator

The review has been properly conformed. Also the requests have been largely fulfilled.

The review has been properly conformed. Also the requests have been largely fulfilled.
Collaborator

This will be merged manually.

This will be merged manually.
b24johka closed this pull request 2026-04-29 07:42:22 +00:00

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!587
No description provided.