Andras/BoundlessFlowCampus2K
4
7
Fork 0
Code Issues 90 Pull requests 7 Projects Releases Packages Wiki Activity Actions

#369-implement-hamburger-menu #587

Closed
a24julot wants to merge 0 commits from #369-implement-hamburger-menu into team_1_week_3
pull from: #369-implement-hamburger-menu
merge into: Andras:team_1_week_3
Conversation 6 Commits - Files changed -
a24julot commented 2026-04-27 11:02:51 +00:00
Collaborator
Copy link

Made a hamburger menu for settings. Can add more choices when necessary.

Made a hamburger menu for settings. Can add more choices when necessary.
menu.png
6.4 KiB
burger.png
804 B
menu.png burger.png 
Updated code to close the menu when user clicks outside the menu.
b24johka commented 2026-04-27 13:07:22 +00:00
Collaborator
Copy link

What has been reviewed?

  • The coding standard is being followed
  • It is what we have requested

However, the hamburger menu doesnt seem responsive in a few areas (See screenshot)

  • The Menu is really big when on a mobile device (Should probably scale down to take up max 50% of screen)
  • The Menu is not aligned with the navbar.
  • The text wont scale down (This might be because REM is relative to parent container, if parent stay the same it will stay the same)

The screenshot is taken through an Iphone 14

**What has been reviewed?** - The coding standard is being followed - It is what we have requested **However, the hamburger menu doesnt seem responsive in a few areas (See screenshot)** - The Menu is really big when on a mobile device (Should probably scale down to take up max 50% of screen) - The Menu is not aligned with the navbar. - The text wont scale down (This might be because REM is relative to parent container, if parent stay the same it will stay the same) The screenshot is taken through an Iphone 14
IMG_8130.png
170 KiB
IMG_8130.png
a24julot commented 2026-04-28 09:43:31 +00:00
Author
Collaborator
Copy link

I am not sure if we are supposed to develop for mobile devices in the same files that we develop for desktop. I saw that there is a question on how we should approach this to the customer in issue #600. So I am not sure what needs to be done at this moment. Will wait for customer feedback.

I am not sure if we are supposed to develop for mobile devices in the same files that we develop for desktop. I saw that there is a question on how we should approach this to the customer in issue https://git.webug.se/Andras/BoundlessFlowCampus2K/issues/600. So I am not sure what needs to be done at this moment. Will wait for customer feedback.
b24johka commented 2026-04-28 09:46:19 +00:00
Collaborator
Copy link

https://www.w3schools.com/css/css_rwd_mediaqueries.asp

https://www.w3schools.com/css/css_rwd_mediaqueries.asp
a24julot commented 2026-04-28 18:56:01 +00:00
Author
Collaborator
Copy link

This has been updated and it should now scale appropriately.

This has been updated and it should now scale appropriately.
settings.png
5.6 KiB
settings1.png
11 KiB
settings.png settings1.png
b24johka commented 2026-04-29 06:46:05 +00:00
Collaborator
Copy link

The review has been properly conformed. Also the requests have been largely fulfilled.

The review has been properly conformed. Also the requests have been largely fulfilled.
b24johka commented 2026-04-29 06:46:16 +00:00
Collaborator
Copy link

This will be merged manually.

This will be merged manually.
b24johka closed this pull request 2026-04-29 07:42:22 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
b24johka
Labels
Clear labels   
_CRITICAL_

Only use this label for critical tasks that are project-scope,and must be addressed ASAP.

  
API

   
app

   
backEnd

   
Blocked, waiting for further changes

   
bug

Something is not working

  
cleanup

Issues to cleanup the codebase (restructure folders, remove deprecated or smelly code)

  
close

Issue to close

  
design

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
feature request

   
frontEnd

   
help wanted

Need some help

  
invalid

Something is wrong

  
low priority

   
needs input

Issue needs input from product owner or customer

  
needs review

issue is in need of review

  
project documentation

   
question

More information is needed

  
research

   
reviewed

This Issue has been reviewed

  
script

   
security

use this for security-related issues

  
SQL

  
style

   
testing

   
topLevel

Reserved for top-level, project-wide issues.

  
wontfix

This won't be fixed

No labels
_CRITICAL_
API
app
backEnd
Blocked, waiting for further changes
bug
cleanup
close
design
duplicate
enhancement
feature request
frontEnd
help wanted
invalid
low priority
needs input
needs review
project documentation
question
research
reviewed
script
security
SQL
style
testing
topLevel
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
b24johka
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Andras/BoundlessFlowCampus2K!587
No description provided.